Skip to content

[Visual] Fix vertex value range in VisualMesh #6432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 1 commit into from
Oct 28, 2026
Merged

[Visual] Fix vertex value range in VisualMesh #6432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Sofa/Component/Visual/src/sofa/component/visual/VisualMesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ VisualMesh::VisualMesh()
"The space between element (scalar between 0 and 1)"))
, d_lighting(initData(&d_lighting, true, "lighting", "If true, light is simulated on the mesh. Otherwise, no lighting effect."))
, d_vertexValues(initData(&d_vertexValues, "vertexValues", "Optional list of values associated to the vertices of the mesh. If provided, the values are converted to colors."))
, d_colorMapRange(initData(&d_colorMapRange, std::array<SReal, 2>{0_sreal, 1_sreal}, "colorMapRange", "Range of values used to convert vertex values to colors. Used only if provided."))
, d_colorMap(initData(&d_colorMap, *sofa::helper::ColorMap::getDefault(), "colorMap", "Color map used to convert vertex values to colors."))
, l_topology(initLink("topology", "Link to a topology containing elements"))
{
Expand Down Expand Up @@ -92,8 +93,20 @@ void VisualMesh::doDrawVisual(const core::visual::VisualParams* vparams)
if (vertexValuesAccessor.size() >= positionAccessor.size())
{
const auto& colorMap = d_colorMap.getValue();
const auto [minIt, maxIt] = std::minmax_element(vertexValuesAccessor.begin(), vertexValuesAccessor.end());
auto colorEvaluator = colorMap.getEvaluator<SReal>(*minIt, *maxIt);
SReal min, max;
if (d_colorMapRange.isSet())
{
const auto& colorMapRange = d_colorMapRange.getValue();
min = std::min(colorMapRange[0], colorMapRange[1]);
max = std::max(colorMapRange[0], colorMapRange[1]);
}
else
{
const auto [minIt, maxIt] = std::minmax_element(vertexValuesAccessor.begin(), vertexValuesAccessor.end());
min = *minIt;
max = *maxIt;
}
auto colorEvaluator = colorMap.getEvaluator<SReal>(min, max);

sofa::type::vector<sofa::type::RGBAColor> vertexColors;
for (const auto& v : vertexValuesAccessor)
Expand Down
1 change: 1 addition & 0 deletions Sofa/Component/Visual/src/sofa/component/visual/VisualMesh.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ class VisualMesh : public core::visual::VisualModel


Data<type::vector<SReal>> d_vertexValues;
Data<std::array<SReal, 2>> d_colorMapRange;
Data<sofa::helper::ColorMap> d_colorMap;

/// The topology will give access to the elements
Expand Down
Loading