Skip to content

[Component] Rename redisue to residual - #6434

Merged
hugtalbot merged 2 commits into
sofa-framework:masterfrom
th-skam:residual-eng
Nov 6, 2026
Merged

hugtalbot merged 2 commits into
sofa-framework:masterfrom
th-skam:residual-eng

Conversation

@th-skam

@th-skam th-skam commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Frenchified version of residual is inconvenient; gets missed by searches. Better now, before release.

[with-all-tests]

@th-skam th-skam added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 29, 2026
@bakpaul

bakpaul commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Do we see a pattern of a specific individual doing the same mistake over and over ? I don't know... That is just some old work residue...
While you're there, mind fixing the french "resolution" into "solving" ? 🧌

@bakpaul

bakpaul commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

More seriously, I cannot see any scene modification in your PR, could you make sure this is not used in any scenes and re-run the ci with all tests ?

@th-skam

th-skam commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]
Do these ⬆️ work still?

I didn't find any reference in scenes. They're ran with defaults.

@bakpaul

bakpaul commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

No there's no need for throwing any ci-build or test tags in comment. In the commit body is enough now. Just the regression tests (and the scene tests but not for long) will fail on windows and it might be unrelated so for windows focus on unit tests...

@th-skam th-skam added pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels Oct 29, 2026
@fredroy fredroy added the pr: breaking Change possibly inducing a compilation error label Nov 3, 2026
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 6, 2026
@hugtalbot
hugtalbot merged commit bff2aa3 into sofa-framework:master Nov 6, 2026
48 of 57 checks passed
@th-skam
th-skam deleted the residual-eng branch November 6, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants