Skip to content

IDC and Debt Fee Release [v3.21] - #193

Closed
softwareengineerprogrammer wants to merge 1 commit into
mainfrom
idc-and-debt-fee-release
Closed

softwareengineerprogrammer wants to merge 1 commit into
mainfrom
idc-and-debt-fee-release

Conversation

@softwareengineerprogrammer

@softwareengineerprogrammer softwareengineerprogrammer commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Description

Follow-up from:

  1. Rename capitalized interest  NatLabRockies/GEOPHIRES-X#542
  2. Construction loan up front fee NatLabRockies/GEOPHIRES-X#540

TODO

  1. Relabel IDC as "Capitalized interest (IDC)" in docs/_images/sam-em-mcy-design-diagram.png
  2. Merge NatLabRockies main into this branch (picks up Rename capitalized interest  NatLabRockies/GEOPHIRES-X#542 rename, 451c712)
  3. Re-capture docs/_images/sam-em-mcy-construction-cash-flow-category.png (still shows Debt interest payment [construction] ($))
  4. docs/SAM-EM_Multiple-Construction-Years.md IDC bullet wording: "Interest on the accumulated debt balance (Capitalized interest [construction]) is calculated using…"
  5. Check GTP web interface (and any other consumers) for lookups of the old row name

Construction loan up-front fee (NatLabRockies#540) fix

  1. Confirm bug: add Construction Loan Up-Front Fee, 0.05 to example_SAM-single-owner-PPA-5.txt; expect Project NPV/IRR to rise vs. no fee (fee is in total installed cost → ITC + depreciation basis, but never paid: IRR/NPV use construction-year rows + SAM Years 1+, dropping SAM Year 0 where equity would implicitly fund it)
  2. Open issue in NatLabRockies/GEOPHIRES-X and link here
  3. Fund fee from equity: add each year's fee to Issuance of equity [construction] (and thus After-tax net cash flow [construction]), consistent with SAM's implicit Year 0 treatment; effective_debt_percent unchanged
  4. Tests: with nonzero fee, equity + debt + capitalized interest = installed cost each year; NPV with fee < NPV without
  5. Rename/reposition Debt up-front fee [construction] ($): it's a use of funds, currently listed among financing sources, and the name reads like SAM's operating-period Debt up-front fee ($) (cost_debt_upfront)
  6. Add fee to design diagram (feeds Installed cost and Issuance of equity)
  7. Tooltip: note the fee is charged on each year's draw (simplification; real up-front fees are usually on the commitment at financial close)

Release

  1. CHANGELOG 3.21 entry: Changed: Debt interest payment [construction] ($) → Capitalized interest [construction] ($) (Rename capitalized interest  NatLabRockies/GEOPHIRES-X#542, Rename Debt interest payment [construction] cash flow row: it's capitalized interest, not a cash payment NatLabRockies/GEOPHIRES-X#529); up-front fee funding fix
  2. bumpversion minor (3.20.1 → 3.21.0; .bumpversion.cfg auto-commits and tags)

Testing & Verification

  1. Unit tests added: Describe new unit tests added, if any.
  2. Unit tests updated: Describe existing unit tests that were updated, if any.
  3. Manual testing: Describe any additional manual testing steps that were performed, such as running the change on a pre-existing data set you own.

Change Checklist

Observe the following checklist items before and after merging, as applicable.

Before merging:

  1. I certify that I am a human and I have manually verified the correctness of the changes in this PR.
  2. Add a CHANGELOG entry if your change includes a new version1 (example). RST Template:
M.m.P: `TITLE <https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER>`__ | `release <https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P>`__

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/vM.m.P
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
 M.m.p: [TITLE](https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P)

Self-reviewed in #193

Footnotes

  1. See versioning notes and version management docs. ↩

@softwareengineerprogrammer softwareengineerprogrammer added the bug Something isn't working label Nov 15, 2026
@softwareengineerprogrammer softwareengineerprogrammer changed the title IDC and Debt Fee Release IDC and Debt Fee Release [v3.21] Nov 15, 2026
@softwareengineerprogrammer

Copy link
Copy Markdown
Owner Author

Rebased: #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant