refactor(providers): move accounts provider off web3.js Connection - #1250
Merged
Woody4618 merged 2 commits intoAug 27, 2026
Merged
Conversation
Batched account fetches, the nested programData lookup and stake activation now go through the central getRpc(url) accessor. Parsed payloads run through withNumbersInsteadOfBigInts before the superstruct validators; lamports stays a bigint through the stake-activation path. Refs: HOO-1264
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe accounts provider now uses the shared Kit RPC client while preserving legacy account representations and explicit confirmed reads.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported commitment regression is fixed because parsed, raw, skip, and nested program-data account requests now explicitly specify confirmed commitment. Important Files Changed
Reviews (2): Last reviewed commit: "chore: greptile feedback" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
askov
approved these changes
Aug 27, 2026
|
|
||
| // The kit-typed shape of a jsonParsed account's `data` when the RPC could parse it — the | ||
| // `[base64, 'base64']` tuple fallback is excluded (callers branch on `Array.isArray` first). | ||
| type ParsedAccountData = Exclude<AccountInfoWithJsonData['data'], readonly [string, string]>; |
Collaborator
There was a problem hiding this comment.
nit: Maybe dedupe type. We already have one in stake-activation.ts. But actually at the moment we don't have a correct place to share types between legacy provider and new code
Woody4618
deleted the
refactor/HOO-1264-kill-connection-accounts-provider
branch
August 27, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the accounts provider's
web3.jsConnectionusage with the Kit RPC client, including parsed, raw, and skip account fetch modes. Preserve legacy account shapes through explicit conversions and update tests to mock the RPC interface.AccountsProvidertests to mock Kit RPC account fetching.Closes HOO-1264 (Refactor provider RPC usage (Kit MIgration))