chore(ENG-9225): mark ModelIngestionResource.complete (completeWithVersion) deprecated - #509
Merged
gjedlicska merged 1 commit intoAug 12, 2026
Conversation
…recated Mirrors the sharp-sdk [Obsolete] marking (ENG-9221) and the server-side GraphQL deprecation (ENG-8970): completeWithVersion bypasses the v2 REST uploads/complete seam, so versions created through it are not viewer-consumable in the bundle era. Warning only — the method stays for deployed packfile-era callers. Replacement: specklepy.bundle.upload.ArtifactPipeline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for specklepy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 89.35% 89.41% +0.05%
==========================================
Files 173 173
Lines 8454 8492 +38
==========================================
+ Hits 7554 7593 +39
+ Misses 900 899 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bimgeek
approved these changes
Aug 12, 2026
gjedlicska
deleted the
gergo/eng-9225-mark-modelingestionresourcecomplete-completewithversion
branch
August 12, 2026 08:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
specklepy twin of the sharp-sdk
[Obsolete]marking (ENG-9221) following the server-side GraphQL deprecation (ENG-8970):completeWithVersionbypasses the v2 RESTuploads/completeseam where the server dispatches dat-generation, so versions created through it are not viewer-consumable in the bundle era.Closes ENG-9225.
What
@deprecated(thedeprecatedpackage, already a dependency) onModelIngestionResource.completein both the core resource and the metrics-tracking api-layer wrapper, sharing one module-level reason constant — the same pattern as the in-flight file-upload deprecation branch.specklepy.bundle.upload.ArtifactPipeline(the v2 RESTuploads/completeflow) as the replacement.Verification
completeemits aDeprecationWarningcarrying the full replacement message.ruff checkandruff format --checkpass on both files.🤖 Generated with Claude Code