[chuuminggg]

This is a follow-up to #1038 / #1040. WebTestClientRequestConverter still mishandles two kinds of Cookie header:

1. A header that contains multiple cookies, as user agents send them (RFC 6265 §5.4), is converted to a single cookie:

   .header(HttpHeaders.COOKIE, "cookieName1=cookieVal1; cookieName2=cookieVal2")

   produces one cookie named cookieName1 with the value cookieVal1; cookieName2=cookieVal2. Using .cookie(name, value) twice works, as each cookie is in a separate header value.

2. A cookie without = fails the conversion:

   .header(HttpHeaders.COOKIE, "cookieName")

   java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 10
   	at org.springframework.restdocs.webtestclient.WebTestClientRequestConverter.createRequestCookie(WebTestClientRequestConverter.java:108)
   

   WebTestClientRequestConverter mishandles cookies whose value contains = and crashes on cookie headers without = #1038 described this case, and WebTestClientRequestConverter mishandles cookies whose value contains = #1040 mentioned handling it by returning an empty value, but the fix that was merged only changed the exception from an ArrayIndexOutOfBoundsException to a StringIndexOutOfBoundsException.

This PR splits each Cookie header value on "; ", in the same way as RestTestClientRequestConverter in main. A cookie without = is converted to a cookie with that name and an empty value. I'm happy to change this to skip the cookie or to throw a clearer exception if you prefer.

The main branch's RestTestClientRequestConverter already splits on "; ", but it has the same createRequestCookie method, so a cookie without = fails there as well. It isn't in 4.0.x, so this PR doesn't change it. It may need the same change when merging forward.

[wilkinsona]

Thanks, @chuuminggg. 3.0.x is no longer supported. Can you please update your PR to use 4.0.x as its base branch?

[chuuminggg]

I've rebased the PR onto 4.0.x and changed its base branch. The tests have also been updated to use JUnit 5 to match the 4.0.x conventions.