Repository navigation
Path parameters snippet uses *name as the name of a {*name} capture variable - #1079
Open
chuuminggg wants to merge 1 commit into
Open
chuuminggg wants to merge 1 commit into
chuuminggg wants to merge 1 commit into
Conversation
Previously, the name of a path variable that captures the rest of the
path, such as {*path}, was determined to be *path rather than path.
Signed-off-by: chuuminggg <rorrxr@naver.com>
chuuminggg
force-pushed
the
path-parameter-catch-all
branch
from
October 16, 2026 10:37
d4ea280 to
e7ccb77
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PathPatternsupports capturing the rest of a path into a variable with{*name}, for example:When such a request is documented with
pathParameters,PathParametersSnippettakes the variable's name to be*pathrather thanpath:The only way to document the parameter is currently
parameterWithName("*path"), which then appears as*pathin the snippet.getParameterNamealready removes a:regexsuffix from the variable. This PR also removes a leading*, so the parameter is namedpath, matching the name that's used with@PathVariable. I've checked this end to end with MockMvc and a@GetMapping("/files/{*path}")controller as well as with the new unit test inPathParametersSnippetTests.This is a change in behavior for anyone who's worked around the problem by documenting
*path. They'd need to documentpathinstead.