Skip to content

ROX-33222: handle multiple hardlinks - #1468

Draft
ovalenti wants to merge 7 commits into
mainfrom
ROX-33222-multiple-hardlinks
Draft

ROX-33222: handle multiple hardlinks#1468
ovalenti wants to merge 7 commits into
mainfrom
ROX-33222-multiple-hardlinks

Conversation

@ovalenti

Copy link
Copy Markdown

Description

When files are tracked via their inode (host), we need to take into account that access may be done using a dentry (path) that is not the monitored one. Also, we need to adapt the kernel "monitored" inode life-cycle to verify if there are paths still monitored. The host_scanner model has to be updated to support several paths per inode.

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 601ad3b8-76ec-4c38-9f78-28f2cc7aa6ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@ovalenti
ovalenti force-pushed the ROX-33222-multiple-hardlinks branch from fc5e66b to 9fb28c1 Compare August 13, 2026 22:29
@codecov-commenter

codecov-commenter commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.90%. Comparing base (d1ad908) to head (9a2b772).

Files with missing lines Patch % Lines
fact/src/host_scanner.rs 0.00% 117 Missing ⚠️
fact/src/event/mod.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1468      +/-   ##
==========================================
- Coverage   34.52%   33.90%   -0.63%     
==========================================
  Files          22       22              
  Lines        3325     3386      +61     
  Branches     3325     3386      +61     
==========================================
  Hits         1148     1148              
- Misses       2172     2233      +61     
  Partials        5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants