Skip to content

chore(support): Do not send failure notification for PRs - #3625

Open
dcaravel wants to merge 1 commit into
masterfrom
dc/limit-alert-triggers
Open

chore(support): Do not send failure notification for PRs#3625
dcaravel wants to merge 1 commit into
masterfrom
dc/limit-alert-triggers

Conversation

@dcaravel

@dcaravel dcaravel commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Updates the CI workflow to only send notifications to slack when a failure occurs from a scheduled or tagged CI run.

Failures from PRs or release branch pushes will no longer generate alerts.

The intent is to reduce noise and ensure alerts are meaningful.

@dcaravel
dcaravel requested a review from a team as a code owner August 14, 2026 19:43
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 22734711-613a-4be7-bb9a-7ccfb8c6d310

📥 Commits

Reviewing files that changed from the base of the PR and between b16889b and 1af8275.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated failure notifications to apply only to scheduled runs and tag pushes.
    • Pull request and branch push failures no longer generate notifications.

Walkthrough

The CI workflow now sends failure notifications only for scheduled runs and tag pushes. Pull request and branch push failures no longer trigger notifications.

Changes

CI notification filtering

Layer / File(s) Summary
Restrict failure notifications
.github/workflows/ci.yaml
The notification job condition now limits failure notifications to scheduled runs and tag pushes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1af82

This localized workflow change limits failure notifications to scheduled or tagged CI runs, reducing Slack noise without any actionable merge-blocking risk remaining.

Suggested reviewers: bradlugo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: suppressing failure notifications for pull requests.
Description check ✅ Passed The description accurately explains the workflow change, affected run types, and purpose of reducing notification noise.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dc/limit-alert-triggers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vjwilson vjwilson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dcaravel

Copy link
Copy Markdown
Contributor Author

/test e2e-tests

1 similar comment
@dcaravel

Copy link
Copy Markdown
Contributor Author

/test e2e-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants