fix unit tests - #2056
Merged
Merged
Conversation
ConfigParser had ml_module_* and https_anomaly_* accessor methods defined twice (interleaved), silently shadowing the earlier definitions and tripping ruff F811. Also drops a duplicate Optional import and trims boilerplate docstrings on the risk-weight accessors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The ml_linear_model/ml_online_model artifact .bin files are stored via Git LFS, but actions/checkout wasn't pulling LFS content, so CI jobs got LFS pointer text files instead of the real pickles, causing _pickle.UnpicklingError: invalid load key, 'v'. in every integration test that loads these modules.
actions/checkout's lfs:true option requires the git-lfs CLI, which isn't present in the stratosphereips/slips_dependencies container image (unlike the GitHub-hosted runner itself), so every job that runs inside that container failed to check out with "Unable to locate executable file: git-lfs".
… arg start_redis_cache_if_not_running() passes a real Output instance as RedisDB's first arg, not an empty string, so the mock assertion never matched.
mark_self_as_done_processing() no longer uses time.time(), so patching slips_files.core.input.input.time failed with ModuleNotFoundError (input.py never imports the time module).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2050