Implementing variable density for unsteady incompressible flow

[tkiymaz]

Proposed Changes

Implements variable density treatment for unsteady incompressible flow simulations. Currently, SU2 uses constant density in transient simulations, which is inaccurate for combustion cases where density varies significantly due to heat release and species composition changes. This contribution enables proper density updates during time-stepping for flamelet-based combustion modeling. For now, only 1st order time marching is implemented

Related Work

Related to incompressible flow solver and flamelet combustion modeling. No specific issue linked yet.

PR Checklist

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
• My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
• I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

[pcarruscag]

@Cristopher-Morales can you review this pr please?

[Cristopher-Morales]

@Cristopher-Morales can you review this pr please?

Hi @pcarruscag !

Yes, I can help reviewing this PR.

Please let me know if you need something else from my side

[bigfooted]

@Cristopher-Morales I guess the changes to the preconditioner can be removed from this PR since we now have your implementation

[bigfooted]

@tkiymaz @pcarruscag
Done from my side, please have a look...

[tkiymaz]

The two remaining CI failures are da_sp_pinArray_cht_2d_dp_hf and da_unsteadyCHT_cylinder. @bigfooted can you check that? I tried but could not find the issue.

[bigfooted]

The two remaining CI failures are da_sp_pinArray_cht_2d_dp_hf and da_unsteadyCHT_cylinder. @bigfooted can you check that? I tried but could not find the issue.

The residuals are barely above the threshold so I would not worry about it. They are both related to a change to the adjoint implementation, but that (unsteady adjoint) needs to be tested in more depth anyway for the variable density case. So I suggest to update the residuals now and create a verification test using finite differences later.

[tkiymaz]

The two remaining CI failures are da_sp_pinArray_cht_2d_dp_hf and da_unsteadyCHT_cylinder. @bigfooted can you check that? I tried but could not find the issue.

The residuals are barely above the threshold so I would not worry about it. They are both related to a change to the adjoint implementation, but that (unsteady adjoint) needs to be tested in more depth anyway for the variable density case. So I suggest to update the residuals now and create a verification test using finite differences later.

Then let me know if there is anything i can do to finalize the PR.

[bigfooted]

The two remaining CI failures are da_sp_pinArray_cht_2d_dp_hf and da_unsteadyCHT_cylinder. @bigfooted can you check that? I tried but could not find the issue.

The residuals are barely above the threshold so I would not worry about it. They are both related to a change to the adjoint implementation, but that (unsteady adjoint) needs to be tested in more depth anyway for the variable density case. So I suggest to update the residuals now and create a verification test using finite differences later.

Then let me know if there is anything i can do to finalize the PR.

just go to the failed testcases overview and copy the line with computed results and update the parallel_regression_AD.py with these values.