Skip to content

Fix the separator so Vale is passed a file list it can read #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcmartin merged 7 commits into from
Oct 21, 2026
Merged

Fix the separator so Vale is passed a file list it can read #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b3729e5
Debug the Vale CI run
kcmartin Oct 21, 2026
6b20c79
Probe Vale's config resolution in CI
kcmartin Oct 21, 2026
ab38fed
Extend the probe: run the action's exact args, and dump VALE env vars
kcmartin Oct 21, 2026
219533d
Probe the action's own vale binary after it runs
kcmartin Oct 21, 2026
71dc18d
Test whether a wrong cwd explains the empty result
kcmartin Oct 21, 2026
0193494
Fix the separator so Vale is passed a file list it can read
kcmartin Oct 21, 2026
763aaf6
Correct the comment: it skipped multi-file PRs, not every PR
kcmartin Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/vale-docs-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,15 @@ jobs:
- name: run reviewdog and linter
uses: errata-ai/vale-action@reviewdog
with:
# tj-actions/changed-files emits a space-separated list, so telling the
# action it is comma-separated made it pass Vale one argument holding
# every path joined by spaces. That is a valid path only when a PR
# changed exactly one file, so from 2023 this check worked on
# single-file PRs and silently skipped every larger one: Vale answers
# an unmatched path with an empty result and exit 0. See
# docs-tracking#375.
files: ${{ steps.changed-files.outputs.all_changed_and_modified_files }}
separator: ","
separator: " "
# added, diff_context, file, nofilter
filter_mode: file
# github-pr-check, github-pr-review, github-check
Expand Down
2 changes: 1 addition & 1 deletion litefs/how-it-works.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

By applying these page sets in the LTX files in order, we can reconstruct the
state of our SQLite database at any point in time. We can also copy them to
another nodes in order to replicate the changes in real-time to our cluster.

Check warning on line 30 in litefs/how-it-works.mdx

View workflow job for this annotation

GitHub Actions / Vale linter 

[vale] reported by reviewdog 🐶
Consider using 'to' instead of 'in order to'.

Raw Output:
{"message":"Consider using 'to' instead of 'in order to'.","location":{"path":"litefs/how-it-works.mdx","range":{"start":{"line":30,"column":15},"end":{"line":30,"column":26}}},"severity":"INFO","code":{"value":"Fly.WordList"}}


### Rollback journal handling
Expand Down Expand Up @@ -85,7 +85,7 @@
## Cluster management using leases

SQLite operates as a single-writer database which means only one transaction can
write at a time. Because of this, we utilize a lease system whereby a single
write at a time. Because of this, we use a lease system whereby a single
node acts as the "primary" node at any given time. All writes should be directed
to that node and it will propagate changes to the rest of the cluster.

Expand Down
Loading