Repository navigation
Skip repository mocking in NoDocumentMockingRule - #367
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
Repositories live in the Entity/Document namespace, so the namespace-based check flagged repository mocks too. Repositories cannot be created directly without a database, so skip classes implementing Doctrine ObjectRepository.
Member
Author
|
Superseded by #372, which was merged to main and already skips Doctrine repositories in NoDocumentMockingRule. Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoDocumentMockingRulematches mocked classes by the\Entity\and\Document\namespace. Repositories live in that same namespace (e.g.App\Entity\UserRepository), so their mocks were flagged too.Unlike entities, repositories cannot be created directly - they need an EntityManager and a database connection. Skip classes implementing
Doctrine\Persistence\ObjectRepository(the base interface of both ORM and ODM repositories).Added a test fixture mocking a repository and a stub for
Doctrine\Persistence\ObjectRepository.