Repository navigation
Extend RequireArrayShapeReturnRule to positional tuple returns - #369
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the rule flagged only methods whose every return was a literal string-keyed array of 2-3 items. Positional arrays were skipped.
Now it also flags methods whose every return is an all-positional literal array of 2-3 items, suggesting a tuple shape:
should declare:
Key style must be consistent: all string keys or all positional. Mixed keys, explicit/computed keys and spreads are skipped, as no single clean shape fits. The existing invariant stays - if any return is not a packed literal array (a variable, a call, a plain value), the method is left alone.
ReportPositionalArrayReturnfixture (now reported)SkipMixedKeyArrayReturnfixture (mixed keys stay skipped)