Repository navigation
Skip "static::" const fetch overridden by child class in ForbiddenStaticClassConstFetchRule - #376
Merged
Conversation
…lassConstFetchRule
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #352.
ForbiddenStaticClassConstFetchRuleflagged everystatic::SOME_CONSTfetch. But late static binding is meaningful when a child class overrides the constant - the value genuinely changes per class, which is the intended use.Rule now uses PHPStan collectors:
StaticClassConstFetchCollector- records eachstatic::CONSTfetch (skipsstatic::classmagic and abstract classes)ClassConstantDeclarationCollector- records each class, its parent and the constants it declaresThe rule reports a fetch only when no child class overrides that constant; when a child redeclares it, the fetch is kept.
static::classis always allowed.How it works
Reported - no child overrides the constant, so
static::behaves likeself:::Skipped - a child class overrides the constant, so late static binding changes the value on purpose:
Skipped -
static::classis late static binding magic, not an overridable constant:Builds on the failing fixture from #373.
Fixtures cover: child overrides const (skip), child without override (report),
static::class(skip).