Repository navigation
Run CommandMustHaveAsCommandAttributeRule only when composer.json requires symfony/console - #380
Open
TomasVotruba wants to merge 1 commit into
Open
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…uires symfony/console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule flagged every
Commandsubclass once the#[AsCommand]attribute class was reachable through reflection, even in projects that only pullsymfony/consoletransitively and never opted into it.Gate the rule on a direct
symfony/consoleentry in the analysed projectcomposer.json(requireorrequire-dev), read once and memoized. Projects that do not depend on the package are left alone.Added
symfony/consoletorequire-devso the rule own test still reports, as the package tests Symfony commands directly.