Skip to content

Check #[AsCommand] attribute class is loadable first in CommandMustHaveAsCommandAttributeRule #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 23, 2026
Merged

Check #[AsCommand] attribute class is loadable first in CommandMustHaveAsCommandAttributeRule #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Rules/Symfony/CommandMustHaveAsCommandAttributeRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

// do not require an attribute the project does not even have
if (! $this->reflectionProvider->hasClass(SymfonyAttribute::AS_COMMAND)) {
return [];
}

// symfony/console must be a direct production dependency, require-dev is skipped
if (! $this->composerRequireResolver->hasRequiredPackage(self::SYMFONY_CONSOLE_PACKAGE)) {
return [];
Expand All @@ -95,11 +100,6 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

// do not require an attribute the project does not even have
if (! $this->reflectionProvider->hasClass(SymfonyAttribute::AS_COMMAND)) {
return [];
}

foreach ($node->attrGroups as $attrGroup) {
foreach ($attrGroup->attrs as $attr) {
if ($attr->name->toString() === SymfonyAttribute::AS_COMMAND) {
Expand Down
Loading