Repository navigation
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
A bare /codetrial-triage now acts on the PRs it grades instead of only listing them. A conflicting PR gets the fixed rebase text as a Request changes review, so it shows as blocked until the author pushes. hygiene.sh turns the requests maintainers keep typing by hand (make hooks, make indent, merge commits, a fork's main, agent co-author trailers, CI regressions, missing screenshots) into one fixed-text review per head, and each low or blocked PR gets a multi-agent review whose verified findings post-inline.sh posts inline. Every post is pinned to the head it was read at, and nothing is asked again that a maintainer already asked at that head, in a review, a comment or on a line. Agy reads contributors' diffs sandboxed and without the maintainer's GitHub token.
The interviewer is a Rust room participant that the web server dispatches, not a LiveKit Agents SDK worker, so the lk agent tools cannot drive it and agents keep reaching for them. codetrial-livekit maps where rooms, tokens, dispatch, agent state, egress and the transport patch live, how to look a LiveKit fact up for the pinned crate, the connection checks, the rules room code follows, and how to upgrade the crates.
A skill's description is all an agent reads before choosing it, so two descriptions claiming the same request, or none claiming it, send work to the wrong instructions with no error anywhere. check-skill-routing.py runs each request in skill-routing-queries.json through claude -p in a throwaway, credential-free copy of the tree and reports which skill fired first. A run that fails, times out or never finishes counts as an error, never as a near-miss that fired nothing. It needs a logged-in claude, so it sits outside the gate; codetrial-verify says when to run it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare
/codetrial-triagenow acts on the PRs it grades: a conflicting PR gets the fixed rebase text as a Request changes review,hygiene.shposts one fixed-text Request changes review for the recurring requests maintainers type by hand (make hooks, make indent, merge commits, a fork's main, agent co-author trailers, CI regressions, missing screenshots), and each low or blocked PR gets a multi-agent review whose verified findingspost-inline.shposts inline. A request a maintainer already made at the current head is never repeated.codetrial-livekitcovers the Rust interviewer's side of LiveKit, andscripts/check-skill-routing.pychecks that each request routes to the skill that owns it; the full query set routes 96 of 96 runs correctly.Validated with
scripts/test.sh portable, the skill-script tests (each new rule mutation-checked), and read-only sweeps over the open PRs.Summary by cubic
A bare
/codetrial-triagenow acts on the PRs it grades instead of only listing them: a conflicting PR gets the fixed rebase text as a Request changes review,hygiene.shposts one fixed-text Request changes review for the recurring requests maintainers type by hand, and each low or blocked PR gets a multi-agent review whose verified findingspost-inline.shposts inline. A request a maintainer already made at the current head is never repeated, including one made on a line of the head.The sweep's reviewer runs with the maintainer's GitHub token nulled so a prompt injection in a contributor's diff cannot post or approve. A similar-work mirror is posted only to an open PR; a pair skipped because a head moved stays out of the ledger and is retried next sweep. The rebase recheck reads per reason: a conflicts entry needs
CONFLICTINGat the same head, a stale_base entry only the head.New Features
codetrial-livekitcovers the Rust interviewer's room loop, join tokens, agent dispatch, egress, and upgrading the LiveKit crates.scripts/check-skill-routing.pyverifies each request inscripts/skill-routing-queries.jsonroutes to the skill that owns it; the full query set routes 96 of 96 runs correctly, and a run count below one or a launch failure fails plainly.hygiene.shrun is skipped and reported as unchecked, never posted, and a review's summary waits until every finding landed.Written for commit ba97f82. Summary will update on new commits.