Repository navigation
fix(cli): improve run and SQL diagnostics - #101
Merged
Merged
Conversation
Fix run JSON admission reporting, add nested sudo guidance for scripts, and make SQL database-name validation errors actionable. Document the v0.19.1 patch release and use gosec-native suppressions for reviewed scanner false positives. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run --jsonpolicy-block stderr reasons and keep blocked results atphase=admission([cli/json] run --json drops the block reason on stderr and reports phase=resolve (breaks the phase=admission predicate from #81) #96).sudowithout--sudo([run] script payload embedding sudo fails with raw remote stderr and no local hint toward --sudo #97).v0.19.1patch changelog entry.Verification
make checkgolangci-lint rungo test -race ./...gosec -track-suppressions -fmt=text -quiet ./...(0 issues)make build-all VERSION=v0.19.1(all six release targets)Closes #96, #97, and #98.