Hold TapTools' own code to the family's warning standard; export tap::tools

[tap]

What this changes

Adds a taptools_warnings interface target and a TAPTOOLS_WERROR option, links the test target against it, and fixes the two warnings it surfaced in a shipping header. Also exports the tap::tools CMake alias, fixes the book's site-url, adds book/book/ to .gitignore, and corrects a stale namespace comment.

Why

TapTools was the one library in the family with no warnings target and no WERROR option. Every sibling carries the pair — AMBITAP_WERROR, TAP_DSP_WERROR, MUTAP_WERROR, TAP_RATIO_WERROR, SRT_WERROR — so the kernel that every TapTools-Max external compiles against was building without -Wall -Wextra -Wpedantic -Wconversion -Wshadow while everything around it was not. The flag set here is deliberately identical to the siblings' rather than a fresh choice.

The tap::tools alias is the one taphouse's namespace convention has documented all along but this repo never created (see tap/TapHouse#6).

Verification

• Turning the flags on surfaced 42 warnings. Two were in a shipping header (vco.h) and are fixed here; the remaining 34 are -Wconversion in test files.
• After the header fix, a full clean rebuild shows include/taptools/ warning-free: header warnings 42 → 0, test-file warnings 34.
• Behavior is unchanged by the header fix: the suite still passes 1,637,526 assertions across 156 test cases, ctest 1/1.
• The book builds with the pinned mdBook v0.4.40 (URL + SHA256 from docs.yml), and the generated 404.html now links /TapTools/ instead of the non-existent /TapTools/book/.
• The new .gitignore rule was verified by creating a file inside book/book/ and confirming git check-ignore -v matches it.

TAPTOOLS_WERROR is left OFF and is not enabled in CI. 34 test-file warnings remain, so switching it on would break the build. This is the same staged approach the siblings took with MSVC /W4 — the flag exists and the warnings are now visible; enabling it waits until the output is triaged.

Notes for the reviewer

The two vco.h fixes are vestigial-parameter removals, and both are worth a glance to confirm you agree they are dead rather than intended:

• tri_tick(double p, double dt, double adt, double tri_pw) never used dt, and both call sites already passed adt for it (tri_tick(p, adt, adt, tri_pw)).
• waveform_out_peek(double p, double adt, …) never used adt — correctly, since peek reads the triangle integrator rather than ticking it, so it adds no BLEP correction and has no use for the window width. That reasoning is now a comment where the parameter used to be.

Both are private helpers of a nested class with no callers outside this header, so removing the parameters cannot affect any consumer.

• Contract change: none. No documented contract point moved — no packing, convention, normalization, latency, or default changed. The header edits are signature-only on private helpers.
• Notebooks not re-executed, correctly: behavior did not change, so the committed executed outputs remain valid.
• The stale comment corrected at the top of CMakeLists.txt still named the pre-split taptools namespace; the actual namespace has been tap::tools since the repo split.
• TapTools::taptools stays alongside the new tap::tools, so no consumer changes. Note the alias is a build-tree target: the installed config package still exports under TapTools::, so find_package consumers see the old spelling until that is migrated too.

---

Generated by Claude Code