Sample for AWS Lambda - #784
Merged
Merged
Conversation
eamsden
force-pushed
the
ea/aws-lambda
branch
3 times, most recently
from
July 15, 2026 17:45
35487c6 to
fdb039a
Compare
dplyukhin
requested changes
Jul 21, 2026
dplyukhin
approved these changes
Jul 22, 2026
|
I ran this sample without issues (as part of the solutions architecture work for a few of my customers). Thank you! |
lennessyy
added a commit
to temporalio/documentation
that referenced
this pull request
Aug 3, 2026
Removes the remaining non-main ref. samples-server keeps ref: main, which is already main. temporalio/samples-java#784 has not merged, so lambda-worker/ exists only on ea/aws-lambda. The java lambda page's three snippets therefore have no source on main and stop tracking upstream. They keep their current content: snipsync only splices IDs it finds in a source and leaves unmatched markers alone. Confirmed by running yarn snipsync against this config, which leaves both lambda pages untouched and reports 712/716 files unchanged.
lennessyy
added a commit
to temporalio/documentation
that referenced
this pull request
Aug 3, 2026
* fix(snipsync): drop duplicate origins and the dead samples-dotnet pin
Snipsync has failed intermittently since 2026-07-20 and on every run since
2026-07-30. Two independent causes.
Duplicate origins. features and reference-app-orders-go were each listed
twice. Sync.js names every download `${repo}.zip` from the repo alone and
fans all origins out through one Promise.all, and unzip() unlinks the
archive when it finishes. Two tasks sharing a filename race: one reads a
partially written or already deleted archive and yauzl throws
Error: unexpected EOF
at node_modules/yauzl/index.js:629:23
from an fs callback, which escapes getRepos()'s try/catch and kills the
process. Hence the intermittency, and hence no "Failed downloading" line
in the logs. The duplicates date to #3932 and #4247.
Dead branch pin. #4663 pinned samples-dotnet to ea/aws-lambda on 07-30.
That sample merged to main in temporalio/samples-dotnet#152 and the branch
was deleted, so every run since has 404'd on the archive download and
burned five retries. Unpinning is safe for the docs page: snipsync only
splices IDs it finds in a source, and leaves unmatched markers untouched,
so the .NET lambda page keeps its current content.
samples-java stays pinned. temporalio/samples-java#784 is still open and
lambda-worker/ exists only on that branch. The pin is collateral-free
today: the branch's only divergence from main outside lambda-worker/ is
.github/workflows/ci.yml, which carries no snippet markers.
Verified by running yarn snipsync locally against this config: completes
in 87s with no crash, 711/716 target files unchanged, and both lambda
pages untouched.
* fix(snipsync): unpin samples-java as well
Removes the remaining non-main ref. samples-server keeps ref: main, which
is already main.
temporalio/samples-java#784 has not merged, so lambda-worker/ exists only
on ea/aws-lambda. The java lambda page's three snippets therefore have no
source on main and stop tracking upstream. They keep their current content:
snipsync only splices IDs it finds in a source and leaves unmatched markers
alone. Confirmed by running yarn snipsync against this config, which leaves
both lambda pages untouched and reports 712/716 files unchanged.
Co-authored-by: Dan Plyukhin <dplyukhin@gmail.com>
Co-authored-by: Dan Plyukhin <dplyukhin@gmail.com>
Co-authored-by: Dan Plyukhin <dplyukhin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added sample for AWS Lambda
Why?
Checklist
Depends on AWS Lambda (Java) sdk-java#2901
Closes
How was this tested:
Deployed a lambda worker to my sandbox AWS account and Temporal cloud.
Any docs updates needed?