Support Spring property placeholders in @WorkflowImpl workers attribute - #2994
Open
sachinsharma3191 wants to merge 1 commit into
Open
Conversation
taskQueues already resolves placeholders via environment.resolvePlaceholders(), but workers did not. Add the same resolution to configureWorkflowImplementationsByWorkerName, configureActivityBeansByWorkerName, and configureNexusServiceBeansByWorkerName. Fixes temporalio#2747
Contributor
|
Thanks for the contrib. Is this PR still in progress? The checklist isn't checked off. If in progress, please convert to a draft PR. Please also update the PR description to use the template we provide. Please also take note of the contributing guidelines - particularly AI-generated PRs. Please make sure to review AI contributions thoroughly yourself before opening a PR. |
Author
|
Thanks for the review! I've updated the PR description to use the repo's template format and checked off the checklist. This addresses issue #2747 — adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
environment.resolvePlaceholders(workerName)in three methods inWorkersTemplate.java:configureWorkflowImplementationsByWorkerNameconfigureActivityBeansByWorkerNameconfigureNexusServiceBeansByWorkerNameWhy?
Issue #2747: the
workersattribute in@WorkflowImpl,@ActivityImpl, and@NexusServiceImpldid not resolve Spring property placeholders like${my.worker.name}. ThetaskQueuesattribute already resolves placeholders, so this makesworkersconsistent.Checklist
resolvePlaceholderscall in all three methodstaskQueuesplaceholder resolution patternFixes #2747