Repository navigation
chore(deps): bump Theengs Decoder to v2.5.0 - #154
Merged
Merged
Conversation
Moves thirdparty/TheengsDecoder from v2.3.0 to v2.5.0, which brings the upstream fixes from theengs/decoder#719 plus the v2.4.x additions (Victron SmartShunt / Orion TR / battery monitors, Schneider Odace WLBL, SwitchBot Meter Pro without CO2, and the "bvpp" primary-property tag). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
1technophile
added a commit
that referenced
this pull request
Oct 26, 2026
#157) The About page shows THEENGS_DECODER_VERSION, which CMake reads at configure time with `git describe --tags` in thirdparty/TheengsDecoder. A reconfigure was supposed to follow the submodule via CMAKE_CONFIGURE_DEPENDS on thirdparty/TheengsDecoder/.git/HEAD, but in a submodule checkout .git is a file ("gitdir: ../../.git/modules/..."), so that path never exists and never changes. An existing build directory therefore kept the old version after the v2.5.0 bump (#154); only fresh configures (CI) picked it up. Watch the HEAD that `git rev-parse --absolute-git-dir` reports instead. Verified in an existing build directory: moving the submodule v2.5.0 -> v2.3.0 -> v2.5.0 re-runs CMake each time and the baked-in version follows (2.5.0 -> 2.3.0 -> 2.5.0). Co-authored-by: Florian <1technophile@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Moves thirdparty/TheengsDecoder from v2.3.0 to v2.5.0, which brings the upstream fixes from theengs/decoder#719 plus the v2.4.x additions (Victron SmartShunt / Orion TR / battery monitors, Schneider Odace WLBL, SwitchBot Meter Pro without CO2, and the "bvpp" primary-property tag).
Checklist: