Repository navigation
[Docs] Follow TileOPs: validate_inputs bounds, int for float members, reviewed 0.x breaks - #87
Merged
Conversation
… reviewed 0.x breaks TileOPs now checks every `in_range` bound of an op's inputs under `validate_inputs`, not only packed offsets, and an op without packed offsets may declare the flag for its bounds alone. The manifest pages, the call steps, the op lifecycle table and the new-op guide said the check covered packed offsets only. An `int` now takes a `float` member when no `int` or `Number` member does, and only a `Maybe[ADT]` is a discriminant that a type family matches by value. The extensions page still stated the earlier rules. The stability page is mirrored in English, but its Chinese page is written by hand, so it is updated to the new compatibility rule: a 0.x minor release may carry a reviewed break, listed in the release notes and in `scripts/ci/api_compat_allow.txt`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows tile-ai/TileOPs#2958 (squash commit 0b1063ad8), after #86 tracked it up to an earlier commit.
Problems
validate_inputschecks only packed offsets; TileOPs now also checks everyin_rangebound, and an op without packed offsets may declare the flag for its bounds alone.inttakes only anintorNumbermember; TileOPs now lets it take afloatmember when neither exists.Maybediscriminant matches by value; TileOPs restricts that toMaybe[ADT].scripts/ci/api_compat_allow.txt.Changes
user-guide/manifest/extensions: thevalidate_inputsrule coversprefix_offsetsandin_range, and other predicates stay the caller's obligation.user-guide/manifest/extensions: thefloatmember row and the member rule accept anintwhen nointorNumbermember takes it.user-guide/manifest/extensions: the type family rule namesMaybe[ADT].user-guide/manifest/calls,user-guide/op/lifecycle,new-op: thevalidate_inputsstep namesin_rangebounds.stability.zh: the compatibility section matches the mirrored English page..zh.mdpair; the design pages, the English stability page and the API pages follow TileOPs at build time and need no edit.