Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 23, 2026
Merged
M3gA-Mind
added a commit
to M3gA-Mind/openhuman
that referenced
this pull request
Oct 23, 2026
…age bus - registry record: version, release URL and the full v0.2.1 asset set: 16 archives (Arch is published for x86_64 only, as `archlinux-rolling-x86_64`), up from 11. Every digest is the GitHub asset digest, equal to the release checksum.toml. - vendor/tinyeventqueues -> a8d1e306a5 (tag v0.2.1, tinyeventqueues main); CONTRACT_VERSION stays (0, 2) - inbound/settings.rs: module_config now carries `storage_callback`, the storage host's bus name, plus its settings_tests assertion. This is W2's change from tinyhumansai#8326 (7ad45b7). It has to ship in the same change as the record: v0.1.3 refuses unknown config keys, and v0.2.1 refuses to load without this one. The host still derives the scope and grant from the authenticated caller. - Cargo.lock and crates/openhuman-app/Cargo.lock: tinyeventqueues and tinyeventqueues-bus 0.1.3 -> 0.2.1 (workspace version is the only manifest change)
Collaborator
Author
|
Superseded by #8327, which carries this change (storage_callback for tinyeventqueues plus its test) together with the tinyeventqueues v0.2.1 re-pin, so the two land in one merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it changes
The tinyeventqueues module keeps its queues in host storage and needs the bus name that serves that storage. It refuses to load without one ("host callback destination is required: set storage_callback in the module configuration"). Today the host never sends it, so the module fails closed and every inbound queue call fails (Q-H2).
inbound::module_confignow adds"storage_callback"(tinystoragedrivers_bus::STORAGE_INTERFACE,ai.tinyhumans.tinystorage.Storage) next toqueuesandpipeline. This is the value #8309 already sends TinyMCP. The module parses it withtinybus::BusName::newand connects throughtinystoragedrivers_busproxy::connect_storage_at.#8309's arm in
modules::ops::module_configis never reached for this module: theevent_queues::MODULE_IDbranch above it returnsinbound::module_configfirst. That is why the key goes here.Why the merge order matters
Settingswith#[serde(deny_unknown_fields)]and has nostorage_callbackfield. A release build would reject this config.So this commit and the registry/gitlink move to v0.2.0 belong in one merge.
Test
inbound::settings::tests::the_module_config_is_what_the_storage_grant_declaresasserts the blob carriesstorage_callback = "ai.tinyhumans.tinystorage.Storage".