test(ci): run scripts/ci/__tests__ in test:scripts by M3gA-Mind · Pull Request #8341 · tinyhumansai/openhuman

M3gA-Mind · 2026-10-23T21:01:53Z

Summary

static:test-inventory is red on main: scripts/ci/__tests__/check-storage-owner.test.mjs is orphaned, because no package script or workflow invokes it.
The inventory's rule is to wire the file into test:scripts rather than allowlist it (ORPHAN_ALLOWLIST "should stay empty"), so test:scripts now also globs scripts/ci/__tests__/*.test.mjs.

Problem

The file holds the resolve-graph fixtures for check-storage-owner.mjs (engine reach through a TSD crate, tag mismatch, allowlisted root, crate naming, vendored-clean tree, direct aws-sdk-s3). None of them have ever run in CI.

Solution

One-line package.json change (1 / 1). The scripts lane (pnpm test:scripts) now runs these fixtures.

Submission Checklist

Tests added or updated — N/A: CI record/config change; validated by the check it repairs
Diff coverage ≥ 80% — N/A: no Rust or app source lines changed
Coverage matrix updated — N/A: no feature rows change
All affected feature IDs listed — N/A: no feature rows change
No new external network dependencies introduced
Manual smoke checklist updated — N/A: no release-cut surface
Linked issue closed — N/A: main-breakage fix, no issue

Impact

CI only. No runtime, platform, migration or compatibility impact.

check-storage-owner.test.mjs (the engine-reach, tag-mismatch, allowlist, crate-name and aws-sdk-s3 fixtures) was invoked by no script, so the test inventory flagged it as orphaned and it never ran. The inventory's rule is to wire it into test:scripts rather than allowlist it.

tinysweeper · 2026-10-23T21:02:01Z

Tiny Sweeper review

Reviewed head: cca5a0b9eb614aa758115d1ea2644d1773c2797c

Verdict: Ready for maintainer review · Priority: none
Coverage: Reviewed 1 of 1 files.
Pull request purpose (title): test(ci): run script…

Diagnostics and supporting details

Full summary

Pull request purpose (title): test(ci): run scripts/ci/__tests__ in test:scripts. Tiny Sweeper completed its review; deterministic results follow.

Review snapshot

Change surface	Files	Review signal
Production	0	Active findings
Tests	0	Noted findings
Documentation	0	Resolved findings
Configuration	1	Pending checks/questions

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The change adds `scripts/ci/__tests__/*.test.mjs` to the `test:scripts` glob so the storage-owner self-test is actually executed by the scripts lane (`scripts/ci/self-hosted/lanes-plan.mjs` runs `pnpm test:scripts` when `areas.scripts` is set). The glob matches the only file present in that directory (`check-storage-owner.test.mjs`, which exists at this commit), the test file has no external dependencies beyond its sibling module, and no other script or config that referenced `test:scripts` forbids the extra path. I found no defect introduced by this diff. _The code index is behind this pull request (indexed at `611f031f81fc`), so retrieved context may be out of date._

security

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The change only adds a glob to the `test:scripts` script so that `node --test` also picks up `scripts/ci/__tests__/*.test.mjs`. The one file present there (check-storage-owner.test.mjs) exists, so the added glob matches; no untrusted input, network, subprocess, secret or permission change is introduced. Nothing reportable. _The code index is behind this pull request (indexed at `611f031f81fc`), so retrieved context may be out of date._

tests

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

Conclusion: Success
Scope reviewed: all assigned evidence
Positive: The commits lane is Answered and reports no sensitive content in committed files.
Lane summary: No sensitive content in committed files. _The code index is behind this pull request (indexed at `611f031f81fc`), so retrieved context may be out of date._

description

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The one-line package.json change adds `scripts/ci/__tests__/*.test.mjs` to `test:scripts`, which matches the PR description exactly and matches the inventory script's stated remedy (`Should stay empty: wire the test into test:scripts`). The directory contains exactly one file, `check-storage-owner.test.mjs`, so the glob picks up the orphaned fixture without pulling in anything unintended, and no runtime, schema or policy code is touched. I found no defect. _The code index is behind this pull request (indexed at `611f031f81fc`), so retrieved context may be out of date._

Evidence and run details

Models: ladder/vectors-oai3, deepseek-v4.1-flash
Spend: $0.004061
Tokens: 126502 input · 2723 output · 45056 cached · 29 embedding
Updated: 2026-10-23T21:03:02Z

Head	State	Pass summary
`cca5a0b9eb61`	ready for maintainer review	0 active finding(s), 0 resolved finding(s) (at 2026-10-23T21:03:02Z)

coderabbitai · 2026-10-23T21:02:04Z

Warning

Review limit reached

Run on-demand review

_{This review includes 1 billable file and costs up to $0.25.}

Or wait 45 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: dda6a2f7-0857-4949-b326-43ea397a52d8

📥 Commits

Reviewing files that changed from the base of the PR and between 8e73d9b and cca5a0b.

📒 Files selected for processing: 1

package.json

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-10-23T21:02:04Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T21:04:21.792018Z	`cca5a0b`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

tinysweeper

tinysweeper found nothing blocking. Approving.

Diagnostics

Total spend: $0.0041

M3gA-Mind · 2026-10-23T22:51:15Z

Superseded by #8334 (merged as d931725). It moved check-storage-owner.test.mjs from scripts/ci/__tests__/ into scripts/__tests__/, which test:scripts already globs, so the test-inventory orphan is gone. scripts/ci/__tests__/ is now empty on main, and the extra test:scripts glob this PR added would match nothing.

tinysweeper Bot approved these changes Oct 23, 2026

View reviewed changes

tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 23, 2026

M3gA-Mind closed this Oct 23, 2026

M3gA-Mind deleted the fix/main-inventory-g3 branch October 23, 2026 22:51

Navigation Menu

Repository navigation

test(ci): run scripts/ci/tests in test:scripts - #8341

test(ci): run scripts/ci/tests in test:scripts#8341
M3gA-Mind wants to merge 1 commit into
tinyhumansai:mainfrom
M3gA-Mind:fix/main-inventory-g3

M3gA-Mind commented Oct 23, 2026

Uh oh!

tinysweeper Bot commented Oct 23, 2026 •

edited

Loading

Full summary

Review snapshot

Features

Tests

Findings

Before merge

critique

security

tests

commits

description

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

tinysweeper Bot left a comment

Uh oh!

M3gA-Mind commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

M3gA-Mind commented Oct 23, 2026

Summary

Problem

Solution

Submission Checklist

Impact

Uh oh!

tinysweeper Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tiny Sweeper review

Full summary

Review snapshot

Features

Tests

Findings

Before merge

critique

security

tests

commits

description

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

tinysweeper Bot left a comment

Choose a reason for hiding this comment

Uh oh!

M3gA-Mind commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tinysweeper Bot commented Oct 23, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading