Repository navigation
Conversation
The Settled implementations for the storage import modules were only gated on the modules feature, so they compiled even when legacy-import was disabled. Adding legacy-import to the cfg conditions keeps these impls aligned with the modules they describe. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Relocated read_master_key_file and key_file_mode_is_other_writable from the encrypted file backend into the key_source module so the file-based key resolution logic lives alongside the rest of the key sourcing code. Also gated profile_master_key_read_only behind the secret-file feature since only the encrypted-file backend uses it. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Moved the master key file reader and its permission check into the encrypted file backend module so the disabled placeholder can share the same surface. The placeholder backend now exposes a profile-scoped read-only lookup that returns an error instead of silently succeeding, keeping behaviour consistent when the secret-file feature is off. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The v1 to v2 layout migration reads the v1 layout, so it is now only compiled when the legacy-import feature is enabled. The session store skips the migration and uses the loaded config directly when that feature is off. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
…ithout-legacy-import main already carries the same feature-gating fixes (Settled impl gates, profile_master_key_read_only, the disabled backend's get_profile_read_only, the layout re-export and the rpc migration gate), so every conflict takes main's version. The disabled backend's duplicate get_profile_read_only that the auto-merge produced is dropped. The PR keeps its embed-check-no-default-modules CI lane. Co-authored-by: Medulla <medulla@tinyhumans.ai>
The runtime module is now compiled unconditionally because the agent domain's agent.run_turn handler drives every turn through runtime::turn_driver regardless of whether the channels feature is enabled. Everything else in runtime keeps its own channels gate. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
…deps Update the lockfile to pick up tinystoragedrivers 2.1.1 and tinychannels-bus 0.1.42, along with the transitive windows, getrandom, and tempfile bumps they pull in. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries #8321 (Build modules without legacy-import or secret-file) onto current
main. The #8321 head branch lives intinyhumansai/openhuman, and the "Disallow creating branches" ruleset blocks every update to it, so the merge withmaincan't be pushed there. This PR has all of #8321's commits unchanged, plus the merge commit and one follow-up fix.Supersedes #8321.
What the merge found
mainhad already landed the same feature-gating fixes as Build modules without legacy-import or secret-file #8321: theSettledimpl gates,profile_master_key_read_onlybehindsecret-file, the disabled backend'sget_profile_read_only, theauto_migratere-export behindlegacy-import, and the rpc migration gate. Every conflict takesmain's version. The auto-merge also produced a secondget_profile_read_onlyinencrypted_file_backend_disabled.rs, which is dropped.embed-check-no-default-modulesCI lane:cargo check -p openhuman-embed --no-default-features --features modules.Follow-up fix:
channels::runtimeungated#8319 moved the channel turn driver from
agent::harness, which had no feature gate, tochannels::runtime::turn_driver.agent::bus(agent.run_turn) calls it in every build. Butchannels/mod.rsdeclaredmod runtimeonly underfeature = "channels", so every no-default embed build broke withcannot find module runtime/unresolved import crate::channels::run_channel_turn. That includes the new lane, the existingembed-check-no-defaultlane, and Chottu's feature set.runtime/mod.rsalready gates each of its submodules onchannelsexceptturn_driver. So the fix is to drop the outer gate onmod runtime.Validation
cargo check -p openhuman-embed --no-default-features --features modules: passescargo check -p openhuman-embed --no-default-features: passescargo check -p openhuman-embed --no-default-features --features langfuse: passescargo check -p openhuman-embed --no-default-features --features storage-mongodb,modules,documents,langfuse,crash-reporting: passescargo check -p openhuman-rpc --no-default-features: passescargo check --workspace --tests: passesnode scripts/ci/check-feature-forwarding.mjs: OKpnpm rust:layout: every step passes except the storage-schema check. That check flagstinychannels-buswhatsapp_*collection names. The failure is already onmain: the vendor gitlink is the same and the checker is unchanged.node --teston the lanes-plan script tests: 69/6912207 tests run: 12207 passed, 23 skipped