Repository navigation
chore(modules): pin TinyEventQueues v0.2.3; fix module-boundaries and gated-test allowlist - #8418
Conversation
v0.2.2 pinned tinystoragedrivers by the short rev bf1f0a9, which static:module-boundaries rejects for the tinyeventqueues-bus contract (tinystoragedrivers-types must come from a full 40-hex git rev): FORBIDDEN [tinyeventqueues-bus] tinyeventqueues-bus -> tinystoragedrivers-types. v0.2.3 (tinyeventqueues#15) pins the full rev 29471a1, the same tinystoragedrivers as vendor/tinystoragedrivers; it is otherwise version-only. Record (16 archives, GitHub digests == checksum.toml), gitlink at the v0.2.3 tag commit 34c23ef, and the tinyeventqueues/-bus lock versions.
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): chore(modules): pin TinyEventQueues v0.2.3; fix module-boundaries and gated-test allowlist. The pull request titled "chore(modules): pin TinyEventQueues v0.2.3; fix module-boundaries and gated-test allowlist" is a version-pin chore that bumps the pinned tinyeventqueues module from 0.2.2 to 0.2.3 in the module registry record, updates the release URL and per-platform archive names and SHA-256 digests, and adds a single entry to the CI gated-test allowlist. According to the description, the pin also fixes main's module-boundaries failure caused by a short git rev in v0.2.2, moves the vendor gitlink forward, and updates lockfiles. No lane reported a defect in the changed files, and the only changed files reviewed in the supplied diff are crates/openhuman-core/src/modules/registry/records_eventqueues.rs and scripts/ci/check-gated-test-allowlist.sh. Test execution is not independently confirmed by trusted check evidence in the provided material; the description's claims about test runs are asserted, not verified here. Unreviewed paths
Review snapshot
Completeness: Complete What changedThe registry record at crates/openhuman-core/src/modules/registry/records_eventqueues.rs updates the tinyeventqueues module's version from 0.2.2 to 0.2.3, its release_url to the v0.2.3 tag, and all 16 per-platform archive filenames and SHA-256 digests to 0.2.3-specific values. The CI script scripts/ci/check-gated-test-allowlist.sh adds channels/host/voice_tests.rs to the EXPECTED allowlist, addressing a gated-test allowlist check that was red on main. Per the whole-pull-request description, the change also moves the vendor/tinyeventqueues gitlink forward to 34c23ef and updates tinyeventqueues and tinyeventqueues-bus versions in Cargo.lock and crates/openhuman-app/Cargo.lock; those lockfile and gitlink deltas were not part of the reviewed diff supplied here. Features
Tests
FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tinyhumansai#8412 gated the STT block of channels/host/voice_tests.rs on the voice feature without adding the file to the gated-test allowlist, so static:gated-test-allowlist is red on main. The gate only compiles out voice-only STT tests when voice is off; it carries no ungated assertion, so the gate-contract filters need no extension.
M3gA-Mind
changed the title
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update release assets and vendor pointer crates/openhuman-core/src/modules/registry/records_eventqueues.rs, vendor/tinyeventqueues |
The registry points to release 0.2.3 and updates filenames and SHA-256 checksums for all 15 platform assets. The vendor submodule reference advances to a new commit. The supported platforms, host keys, and archive formats remain unchanged. |
Gated-test allowlist
| Layer / File(s) | Summary |
|---|---|
Add host voice test entry scripts/ci/check-gated-test-allowlist.sh |
The expected gated-test file list now includes channels/host/voice_tests.rs. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related PRs
- tinyhumansai/openhuman#8412: Updates TinyEventQueues to v0.2.2 and advances the vendor submodule; this PR continues the pin to v0.2.3 and updates the related test allowlist.
- tinyhumansai/openhuman#8327: Updates the same registry record and vendor submodule from earlier releases.
- tinyhumansai/openhuman#8399: Adds an end-to-end test that loads the staged TinyEventQueues release used by this update.
Suggested reviewers: senamakel
Merge Risk: 
ded34
-
No actionable correctness, availability, security, or integration risk was found in the changed files.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title accurately identifies both primary changes: pinning TinyEventQueues v0.2.3 and updating the module-boundaries and gated-test allowlist fixes. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks each checksum line,
The release tag reads two-point-three.
The voice test joins the list today,
The vendor pointer hops its way.
Then carrots crunch in harmony.
Comment @coderabbitai help to get the list of available commands.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
This pins TinyEventQueues v0.2.3 and fixes main's two red static checks. The pin fixes the
static:module-boundariesfailure that main has had since #8412:The boundary check resolves each
*-buscontract in its own workspace. It acceptstinystoragedrivers-typesonly from crates.io or from a full 40-character git rev.bf1f0a9, so the check rejected it.29471a164619bcec03e5858a7d7ee0c65f52bf22, which is the same tinystoragedrivers asvendor/tinystoragedrivers. Apart from that, the release only changes version numbers.Changes
records_eventqueues.rsnow has version 0.2.3, the new release URL, and the 16 archive names and digests. Each digest is the GitHub release asset digest, and all 16 match the release'schecksum.toml.vendor/tinyeventqueuesmoves from b2165be to 34c23ef (the v0.2.3 tag commit). This is a forward move.tinyeventqueuesandtinyeventqueues-busgo from 0.2.2 to 0.2.3 in the root lock, andtinyeventqueues-busdoes the same in the app lock. Nothing else changes.Checks
Run on a remote host at fe31d57, compared against main fd63b94:
cargo metadata --lockedpasses for the root and app locks, and leaves the tree clean.static:module-boundaries: main has 1 violation, this branch has 0, so the failure is fixed.static:module-pinsandstatic:submodule-monotonicpass. The only gitlink that moves isvendor/tinyeventqueues, and it moves forward.cargo test -p openhuman --lib(product features, run afterinstall-test-modules): 104 passed, 0 failed. That includesmodules::registry24/24,modules::event_queues1/1 andinbound::72/72.cargo fmt --all --checkpasses.Also: gated-test allowlist
static:gated-test-allowlistis red on main fd63b94. #8412 gated the STT block ofchannels/host/voice_tests.rson thevoicefeature but did not add the file toEXPECTEDinscripts/ci/check-gated-test-allowlist.sh. This PR adds that entry.The gate only compiles out voice-only STT tests when
voiceis off. It carries no ungated assertion of the #5022 class, so the gate-contract filters don't need extending. Earlier allowlist additions such as 90f5eb1 were list-only too.Summary by CodeRabbit