Skip to content

Bump tinyagents: served_by, response_id and first_token_ms on model observations - #8420

Merged
senamakel merged 14 commits into
tinyhumansai:mainfrom
senamakel:langfuse-model-call-facts
Oct 26, 2026
Merged

senamakel merged 14 commits into
tinyhumansai:mainfrom
senamakel:langfuse-model-call-facts

Conversation

@senamakel

@senamakel senamakel commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Summary

Problem

  • Embedders that export model calls to Langfuse cannot see:
    • which upstream provider a routing gateway (OpenRouter) used for a call;
    • the provider's response id, to look the call up afterwards;
    • time to first token (completionStartTime is null).

Solution

  • A gitlink bump only. OpenHuman matches TurnObservation::Model / ModelDispatch with .. everywhere, so no host code changes are needed. No [patch] tables changed.

Pin and lockfile: [pin-rewind], a sideways move

Submission Checklist

  • Tests added or updated: N/A here. The behaviour and its tests live in tinyagents#582, per OpenHuman's test-ownership rule.
  • Diff coverage ≥ 80%: N/A. There are no changed Rust lines, only a gitlink and lockfiles.
  • Coverage matrix updated: N/A. No product feature row changes.
  • All affected feature IDs listed: N/A.
  • No new external network dependencies introduced.
  • Manual smoke checklist updated: N/A. Not a release-cut surface.
  • Linked issue closed via Closes #NNN in ## Related.

Impact

  • New observation fields for embedders. Breaking only for code that constructs TurnObservation::Model / ModelDispatch or PhysicalDispatchOutcome; nothing in this repository does.
  • Langfuse OTLP generations split reasoning out of output into output_reasoning_tokens. total is unchanged.

Validation (run locally on this branch, merged with main 64599d76c7)

  • node scripts/ci/check-submodule-monotonic.mjs origin/main HEAD: OK. The sideways move is declared with [pin-rewind].
  • scripts/ci/fetch-submodule-tags.sh then node scripts/ci/check-module-pins.mjs: OK, 13 records, all pins accounted for.
  • rust:layout scripts, all pass:
    • check-openhuman-rust-layout
    • check-crate-chain
    • check-core-hosted-free
    • check-storage-bypass
    • check-storage-owner
    • check-storage-schema
    • check-test-ownership
  • cargo check --locked --workspace --all-targets: pass.
  • cargo check --locked --manifest-path crates/openhuman-app/Cargo.toml: pass.
  • rust:clippy: pass:
    • cargo clippy --locked -p openhuman -p openhuman-cli -p openhuman-tinyhumans -- -D warnings
    • cargo clippy --locked --manifest-path crates/openhuman-app/Cargo.toml -- -D warnings
  • cargo metadata --locked on both manifests: pass.
  • cargo test -p openhuman-embed, the observer host tests:
    • turn_observers: pass.
    • --lib complete: 33 passed.
    • observed_turns::model_and_tool_observations_capture_payloads_only_with_consent and dispatch_admission_turn::repair_refusal_is_typed_and_does_not_reach_fallback_or_emit_a_phantom_dispatch fail. They fail identically with main's tinyagents pin (c1d350544), so this bump does not cause them.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: langfuse-model-call-facts

Summary by CodeRabbit

  • Chores
    • Updated a bundled component. The available change details do not indicate any user-facing feature changes or changes to public functionality.
    • No additional end-user impact is specified in the change summary.

senamakel and others added 8 commits October 26, 2026 19:15
Update the vendored tinyagents submodule to the latest upstream commit.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the vendored tinyagents submodule to the latest upstream commit.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updated the pinned commits for all twenty vendored tiny submodules to their current upstream revisions.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The merge picked up the worktree's stale submodule checkouts. Put every
gitlink back on what origin/main records.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
Points at tinyhumansai/tinyagents#582 (not yet merged): model
observations gain the serving provider, the provider's response id and
the time to first token. Repin to the merged/released commit before
this is marked ready.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The lockfile now pins the tinyagents family of crates at 3.0.0 instead of
3.1.2, keeping the app's resolved dependency versions in sync with the
workspace.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a0da707-726f-463a-95a8-55cc5612539d
Commits

Reviewing files that changed from the base of the PR and between 64599d7 and cec03ea.

Files ignored due to path filters: 2
  • Cargo.lock is excluded by !**/*.lock
  • crates/openhuman-app/Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1
  • vendor/tinyagents

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The vendor/tinyagents submodule pointer changes from c1d350544645d6027a486647ad90fb4c73a44d09 to 89df634d38fba07fcfc50ad2a9c556b7896e84da.

Changes: Tinyagents pin update

Layer / File(s) Summary
Update tinyagents pin
vendor/tinyagents
The submodule pointer changes to commit 89df634d38fba07fcfc50ad2a9c556b7896e84da.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • tinyhumansai/openhuman#8412 — This PR updates the same submodule pin from the commit selected in PR #8412 to the newer tinyagents commit.

Suggested reviewers: m3ga-mind

Merge Risk: Minimal · up to cec03

The requested dependency pin change introduces no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: bumping the vendored tinyagents pin so model observations expose served_by, response_id and first_token_ms. The objectives confirm the pin update to the merged commit …
Linked Issues check Passed Direct issue #8419 requires the tinyagents pin to include tinyagents#582. The gitlink changes from c1d350544 to merged commit 89df634d, which contains that change. The reported behavior adds `served_b…
Out of Scope Changes check Passed The reviewed change is limited to the tinyagents gitlink and lockfile synchronization described for issue #8419. The lockfile updates support the pin and restore compatible dependency resolutions. No …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Title check

Explanation

The title names the main change: bumping the vendored tinyagents pin so model observations expose served_by, response_id and first_token_ms. The objectives confirm the pin update to the merged commit with tinyagents#582 is the core change, and the title's specific fields match the linked issue #8419. The title is accurate and specific, though it does not mention the lockfile changes or the reasoning-token export.

Full details: Linked Issues check

Explanation

Direct issue #8419 requires the tinyagents pin to include tinyagents#582. The gitlink changes from c1d350544 to merged commit 89df634d, which contains that change. The reported behavior adds served_by, response_id, and first_token_ms to model observations and exports reasoning tokens as output_reasoning_tokens. OpenHuman host code uses variant matches with .., so no host-code change is required. The reported OpenHuman checks pass, and the listed test failures reproduce with the base pin.

Full details: Out of Scope Changes check

Explanation

The reviewed change is limited to the tinyagents gitlink and lockfile synchronization described for issue #8419. The lockfile updates support the pin and restore compatible dependency resolutions. No unrelated product code or unrelated behavior change is identified.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the pinned commit with care,
Tinyagents moves to a newer share.
Three fields travel in the code’s new stream,
Response facts join the token-time gleam.
The carrot waits; the pointer’s set,
One small hop completes the set.

Comment @coderabbitai help to get the list of available commands.

senamakel and others added 6 commits October 26, 2026 21:01
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the vendored tinyeventqueues submodule to the latest upstream commit.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Downgrade the tinyeventqueues and tinyeventqueues-bus lockfile entries from 0.2.3 to 0.2.2 and advance the vendored tinyagents submodule to a newer commit.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
[pin-rewind]: vendor/tinyagents moves from c1d350544 (tag v3.1.2) to
89df634d3, the merge of tinyagents#582 and the tip of tinyagents main.
The tag commit is a release-only commit off main (it only bumps crate
versions 3.0.0 -> 3.1.2), so the move is sideways and loses nothing but
those version numbers; every code change in v3.1.2 is on main and in
89df634. No tinyagents release contains #582 yet. The lockfiles follow
the crates back to 3.0.0 until a release is pinned.

Also restores vendor/tinyeventqueues to main's v0.2.3 pin, which an
earlier checkpoint on this branch had rewound by mistake.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
The lockfile now pins windows-core 0.57.0 instead of 0.58.0 for the affected dependency, keeping the resolved version consistent with the rest of the tree.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The regeneration had re-picked windows-core/windows-sys for
iana-time-zone and winapi-util; main's choices still satisfy
`cargo metadata --locked`, so the lockfile diff is only tinyagents.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel marked this pull request as ready for review October 26, 2026 18:26
@tinysweeper

tinysweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Reviewed head: cec03ea5bb32c413d281c238f5a4980531df9b01

Verdict: Ready for maintainer review · Priority: none
Coverage: File coverage is unavailable.
Pull request purpose (title): Bump tinyagents: ser…

Diagnostics and supporting details

Full summary

Pull request purpose (title): Bump tinyagents: served_by, response_id and first_token_ms on model observations. Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: No sensitive content in committed files. _The code index is behind this pull request (indexed at `362ad3ea382e`), so retrieved context may be out of date._

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: ladder/vectors-oai3
  • Spend: $0.000002
  • Tokens: 0 input · 0 output · 0 cached · 17 embedding
  • Updated: 2026-10-26T18:28:24Z
Head State Pass summary
cec03ea5bb32 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-26T18:28:24Z)

tinysweeper 0.1.2

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T18:28:43.478661Z
We couldn’t complete this review. Comment @codex review to try again.
cec03ea Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

Diagnostics

Total spend: $0.0000

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 26, 2026
@senamakel
senamakel merged commit e4f011f into tinyhumansai:main Oct 26, 2026
31 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pick up tinyagents model-call facts: served_by, response_id, first_token_ms

1 participant