Repository navigation
feat(labels): add the Keenable display name - #28
Conversation
Tiny Sweeper reviewThis pull request adds a display label for the `keenable` provider id: one new match arm in `provider_label` in crates/tinysearch-bus/src/labels/mod.rs and a matching case in the `known_ids_map_to_display_names` test in crates/tinysearch-bus/src/labels/mod_tests.rs. All five review lanes (critique, security, tests, commits, description) returned no findings. The change is a pure, I/O-free table entry with no new call paths and no API or behavior change beyond the added mapping. State: Ready for maintainer review Review snapshot
Completeness: Complete Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["provider_label<br/>changed"]:::changed
n1["heading"]:::impacted
n1 -->|calls| n0
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0004 · 81,197 in / 4,143 out · 27,648 cached (34%) · ladder/vectors-oai3, deepseek-v4.1-flash · 60 embedded
critique: $0.0001 · 27,845 in / 789 out · 13,312 cached (48%) · deepseek-v4.1-flash
security: $0.0001 · 26,879 in / 641 out · 11,264 cached (42%) · deepseek-v4.1-flash
tests: $0.0001 · 13,026 in / 372 out · 0 cached (0%) · deepseek-v4.1-flash
description: $0.0001 · 11,916 in / 1,113 out · 3,072 cached (26%) · deepseek-v4.1-flash
Summary
Adds
keenabletoprovider_label, so Keenable (added in #10) shows as "Keenable" instead of its raw id. Since #24 moved the label table here, the openhuman settings panel and rendered results read it from the bus, and the host copy that openhuman#7279 extended is gone.Related issue
None. Follow-up to #10 and #24; openhuman#7279 consumes it.
API or behavior changes
None beyond the new table entry. Unknown ids still pass through unchanged.
Validation
Commands actually run, with their outcome:
cargo fmt --all -- --check: cleancargo clippy --all-targets --all-features -- -D warnings: clean on 1.98cargo build --all-targets --all-features: okcargo test --all-features: 220 passed, 0 failedTests
known_ids_map_to_display_namesgains thekeenablepair.Documentation
Not needed: the label table has no separate docs.
Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the description🤖 Generated with Claude Code