Skip to content

feat(labels): add the Keenable display name - #28

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
keenableai:keenable-label
Oct 14, 2026
Merged

senamakel merged 1 commit into
tinyhumansai:mainfrom
keenableai:keenable-label

Conversation

@ilya-bogin-keenable

Copy link
Copy Markdown
Contributor

Summary

Adds keenable to provider_label, so Keenable (added in #10) shows as "Keenable" instead of its raw id. Since #24 moved the label table here, the openhuman settings panel and rendered results read it from the bus, and the host copy that openhuman#7279 extended is gone.

Related issue

None. Follow-up to #10 and #24; openhuman#7279 consumes it.

API or behavior changes

None beyond the new table entry. Unknown ids still pass through unchanged.

Validation

Commands actually run, with their outcome:

  • cargo fmt --all -- --check: clean
  • cargo clippy --all-targets --all-features -- -D warnings: clean on 1.98
  • cargo build --all-targets --all-features: ok
  • cargo test --all-features: 220 passed, 0 failed

Tests

known_ids_map_to_display_names gains the keenable pair.

Documentation

Not needed: the label table has no separate docs.

Checklist

  • The change is focused on one logical change
  • No new #[allow(...)], #[ignore], or relaxed lints
  • No secrets, tokens, or .env contents in the diff or the description

🤖 Generated with Claude Code

@tinysweeper

tinysweeper Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

This pull request adds a display label for the `keenable` provider id: one new match arm in `provider_label` in crates/tinysearch-bus/src/labels/mod.rs and a matching case in the `known_ids_map_to_display_names` test in crates/tinysearch-bus/src/labels/mod_tests.rs. All five review lanes (critique, security, tests, commits, description) returned no findings. The change is a pure, I/O-free table entry with no new call paths and no API or behavior change beyond the added mapping.

State: Ready for maintainer review
Priority: none
Reviewed head: 6278a099cda3
Updated: 2026-10-14T05:19:21Z

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 0
Tests 1 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

  • Added — Keenable provider display label: `provider_label("keenable")` now returns the display name "Keenable" instead of falling through to the `other => other` arm and returning the raw id, so the provider renders with a proper display name alongside the other ten ids in `PROVIDERS`. The mapping is a pure, I/O-free table entry with no untrusted input and no new call paths; no other behavior changes. (crates/tinysearch-bus/src/labels/mod.rs, crates/tinysearch-bus/src/labels/mod.rs#pub fn provider_label(provider: &str) -> Cow<'_, str> {)

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["provider_label<br/>changed"]:::changed
  n1["heading"]:::impacted
  n1 -->|calls| n0
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change adds the missing `keenable` entry to the `provider_label` table and a matching assertion in the sibling test, so all eleven ids in `PROVIDERS` now map to a display name; the spelling matches the provider's own docs, the test file keeps the required `use super::*;` layout, and nothing else in the crate depends on the previous pass-through behaviour for `keenable`. No defects found.

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The change is a pure, I/O-free table entry with no untrusted input, no new call paths, and no rule violations.
  • Lane summary: The change adds a display label for the `keenable` provider id and a matching test assertion; it is a pure, I/O-free table entry with no untrusted input, no new call paths, and no rule violations. Nothing to report.

tests

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The new branch is covered by a matching assertion in the diff that exercises `provider_label("keenable")` through the existing case table and would fail if the arm were removed.
  • Lane summary: Adding a `keenable` arm to `provider_label` is a one-line mapping change with a matching assertion in `mod_tests.rs` that runs `provider_label("keenable")` through the existing case table and would fail (returning `"keenable"`) if the arm were removed, so the new branch is pinned by a test in the diff. Nothing else in the change is behavioural; no defects found.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Positive: Nothing sensitive found in what this pull request commits.
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The description accurately and completely states the one-entry label-table addition with a test; no API or behavior change beyond it.
  • Lane summary: The diff adds a single `"keenable" => "Keenable"` arm to `provider_label` in crates/tinysearch-bus/src/labels/mod.rs plus the matching pair in `known_ids_map_to_display_names` in mod_tests.rs, and the description says exactly that — a one-entry label-table addition with a test, no API or behavior change beyond it. The description is accurate and complete for this change; I found nothing to report.
Evidence and run details
  • Models: ladder/vectors-oai3, deepseek-v4.1-flash
  • Spend: $0.000399
  • Tokens: 81197 input · 4143 output · 27648 cached · 60 embedding
Head State Pass summary
6278a099cda3 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-14T05:19:21Z)

tinysweeper 0.1.2

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c574837-3a1f-411c-bb58-d2e8bd3dc615
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0004 · 81,197 in / 4,143 out · 27,648 cached (34%) · ladder/vectors-oai3, deepseek-v4.1-flash · 60 embedded
critique:    $0.0001 · 27,845 in / 789 out   · 13,312 cached (48%) · deepseek-v4.1-flash
security:    $0.0001 · 26,879 in / 641 out   · 11,264 cached (42%) · deepseek-v4.1-flash
tests:       $0.0001 · 13,026 in / 372 out   · 0 cached (0%)       · deepseek-v4.1-flash
description: $0.0001 · 11,916 in / 1,113 out · 3,072 cached (26%)  · deepseek-v4.1-flash

@senamakel
senamakel merged commit ec863c4 into tinyhumansai:main Oct 14, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants