Repository navigation
Conversation
Auto-committed-on: macbook
Updates the client and module manifests, the vendored gitlink, and the release workflow's reusable workflow pins to TinyBus 0.3.3. The new release publishes a streamed call's terminal verdict before reader EOF, so successful completion and remote failure stay distinguishable when a host consumes a stream. Auto-committed-on: macbook
The regex matching the indexed submodule commit was updated to reflect the current git ls-files output format, where the commit hash is followed by a stage number rather than a tab. This keeps the SDK version check working against current git versions. Auto-committed-on: macbook
Delete the cached cpython-313 bytecode for test-sdk-version so generated artifacts stay out of version control. Auto-committed-on: macbook
Adds the SDK version test to the feature test script so its checks run alongside the other version and portability tests. Auto-committed-on: macbook
The guard now inspects the gitlink recorded in the HEAD tree instead of comparing staged and unstaged pointer states. This keeps the check runnable in a clean nonrecursive checkout while still asserting the pinned TinyBus commit. Auto-committed-on: macbook
Extend the SDK version test to check that the tinyvoice client test fixtures declare version 0.3.3, so the fixtures stay in step with the published crate version. Auto-committed-on: macbook
Update the release record fixtures in the client tests to report version 0.3.3 so they match the current crate version. Auto-committed-on: macbook
The release workflow now pins two distinct reusable workflow commits, one for ordinary module releases and one for reviewed epic releases. The test was updated to expect both pins instead of the previous single shared commit. Auto-committed-on: macbook
Updates the pinned commit for the shared module-release workflow to the latest revision so releases pick up its current behavior. Auto-committed-on: macbook
Auto-committed-on: macbook
…ates/tinyvoice-module/Cargo.tom Auto-committed-on: macbook
Auto-committed-on: macbook
Auto-committed-on: macbook
Updates the locked tinybus version from 0.3.2 to 0.3.3 and records the tinybus-macros and tinybus-module patch entries as unused. The lockfile was regenerated after the dependency bump. Auto-committed-on: macbook
Updates the lockfile to tinybus 0.3.3 along with its macros and module crates, and pins getrandom back to 0.3.4 to match the dependency graph. Auto-committed-on: macbook
Tiny Sweeper reviewTiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsNo active actionable findings. Could not review: .github/workflows/release.yml, Cargo.toml, crates/tinyvoice-client/Cargo.toml, crates/tinyvoice-client/README.md, crates/tinyvoice-client/src/lib_ownership_tests.rs, crates/tinyvoice-client/src/lib_tests.rs, crates/tinyvoice-module/Cargo.toml, scripts/test-features.sh, scripts/test-sdk-version.py, tinysweeper/description, tinysweeper/tests Before merge
How this fits togetherflowchart LR
n0["close"]:::impacted
n1["fixture"]:::impacted
n2["handoff_fixture"]:::impacted
n3["move_public_alias_to_b"]:::impacted
n4["...ces_fail_closed_after_their_peer_detaches"]:::impacted
n5["..._each_operation_and_close_only_explicitly"]:::impacted
n4 -->|calls| n0
n4 -->|tests| n0
n4 -->|calls| n2
n4 -->|tests| n2
n4 -->|calls| n3
n4 -->|tests| n3
n5 -->|calls| n0
n5 -->|tests| n0
n5 -->|calls| n1
n5 -->|tests| n1
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: .github/workflows/release.yml, Cargo.toml, crates/tinyvoice-client/Cargo.toml, crates/tinyvoice-client/README.md, crates/tinyvoice-client/src/lib_ownership_tests.rs, crates/tinyvoice-client/src/lib_tests.rs, crates/tinyvoice-module/Cargo.toml, scripts/test-features.sh and 3 more.
$0.0001 · 0 in / 0 out · 586 embedded · ladder/vectors-oai3
tinysweeper
Bot
added
the
priority: p3
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f360497263
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add a test asserting the tinyvoice-client crate is marked as not publishable and that its README documents the path dependency and git checkout consumption model. This locks in the intent that the client is consumed from source rather than published to crates.io. Auto-committed-on: macbook
Set publish = false and document that the crate is consumed from source via a path or Git dependency. Registry packaging would drop the TinyBus Git revision and could yield a different Rust ModuleClient type than the linked host. Auto-committed-on: macbook
The SDK version test expected the phrase "registry package" in the README, but the README now uses "Registry packaging", so the assertion was updated to keep the test passing. Auto-committed-on: macbook
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinyvoice-client/Cargo.toml, crates/tinyvoice-client/README.md, scripts/test-sdk-version.py, tinysweeper/description, tinysweeper/tests.
$0.0001 · 0 in / 0 out · 629 embedded · ladder/vectors-oai3
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: .github/workflows/release.yml, Cargo.toml, crates/tinyvoice-client/Cargo.toml, crates/tinyvoice-client/README.md, crates/tinyvoice-client/src/lib_ownership_tests.rs, crates/tinyvoice-client/src/lib_tests.rs, crates/tinyvoice-module/Cargo.toml, scripts/test-features.sh and 3 more.
$0.0001 · 0 in / 0 out · 629 embedded · ladder/vectors-oai3
82f96e9
into
tinyhumansai:epic/8056-modules-wiring
TinyVoice's client and native module now use the published TinyBus 0.3.3 SDK, which fixes stream completion ordering. The normal SDK dependencies use one canonical Git source with compatible
>=0.3.3, <0.4.0bounds; both standalone workspaces patch all SDK crates to the pinned vendor checkout. This lets a host unify its SDK dependency while keeping the module built with the known 0.3.3 release. The normal client remains free of loader features.The typed client is explicitly Git/path-only (
publish = false). Its README describes source consumption and why a registry-normalized SDK dependency would defeat the host's canonical Git patch strategy. A regression guard requires this policy and documentation.Prepares native module 0.3.3 and refreshes the two lockfiles. Release guards verify the SDK minimum, parent gitlink and nonrecursive checkout behavior. The existing ordinary release delegate is preserved, and the reviewed-epic path uses the corrected shared publication workflow.
Validation:
.sopath; the real instrumented.dylibpassed the equivalent verifier and thresholds. Linux's unchanged stock coverage job remains required in CI.modules.toml. Local console evidence is retained as excerpts rather than full persistent logs; hosted Linux/macOS/Windows checks must pass before merge. Windows/PowerShell execution is not claimed locally.No Rust API or runtime behavior changes. The full OpenHuman normal/desktop SDK graph and host integration remain separate epic work.
Refs senamakel#1. Part of tinyhumansai/openhuman#8056.