Repository navigation
Conversation
What was broken Sales App users could select only one stage or column filter value, and could not filter opportunities by numeric amount ranges. Root cause The UI stored one filter value and one selected stage, serialized scalar query parameters, and provided no controls for numeric amount comparisons. What was changed Allow multiple stage tiles and OR column values. Add debounced greater-than and less-than amount controls with range validation. Send repeated value parameters to the Reports API, reset pagination on changes, preserve independent filters, and document the controls and API-first rollout. Any added/updated tests Add UI and utility regressions for multiple selections, removing selections, combined filters, amount validation, clearing, refresh and pagination resets. Add request serialization coverage, including values containing commas. All 66 Sales tests, lint and production build pass. The full UI suite has the same 21 failing suites and 18 failed tests as the unchanged base branch; 2,921 tests pass, including all seven added tests.
PM-6639: Add multi-value and amount filters to Sales App
What was broken In production, Highcharts labelled 500k-interval currency axes on the monthly dashboards as "1 000k" and "2 000k". The Sales README still said revenue stays pending until column IDs are configured, and it did not describe Closed Won's stage. What was changed Format y-axis ticks compactly in each chart's unit, for example $1.5M, -$30K, 40 or 12.5%. Update the README for the API's default revenue columns, the offering and account category revenue breakdowns, Closed Won counting Won - SOW Signed, and the per-run fiscal-year filter replacement. Any added/updated tests Added axis label cases for currency, negative, zero, count and percent values. All 146 Sales and Reports app tests pass. yarn lint and the production build pass; the build has only the existing warnings from other packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PM-6632: Compact dashboard axis labels and document live revenue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/
What's in this PR?