Repository navigation
Fix AWS CLI JSON parsing during OIDC deployment - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Challenge API dev deployment with v2.0.1 stopped before contacting AWS because the pinned AWS CLI opens
file:///dev/stdinmore than once. The subprocess pipe is exhausted on the second read, producingParamValidation: Invalid JSON received.Use an anonymous Linux memory file for subprocess input so each open can read the complete JSON. Credentials and request bodies remain outside command arguments and named filesystem files, and descriptors close on success and failure. The existing IAM restrictions and deployment gates are unchanged.
Validation:
After merging, publish a new patch release and update the Challenge API suite tag/commit pin before retrying dev. The failed run pushed no candidate image and left the existing ECS service unchanged.