Repository navigation
Accept optional ECS circuit breaker settings during preflight - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Challenge API dev retry successfully assumed its OIDC deployment role, then stopped before image publication because the circuit-breaker preflight compared the entire ECS object with
{enable: true, rollback: true}. The pinned AWS CLI also returns the documented optionalresetOnHealthyTaskandthresholdConfigurationfields, causing a false rejection even though rollback is enabled.Require both safety flags to be literal
true, while accepting and preserving optional service settings. Missing, false, numeric, string, or malformed flags still fail before publication or task registration. The deployment does not modify circuit-breaker configuration or require new IAM permissions.Validation:
After merging, release v2.0.3 and update the Challenge API tag/commit pin through a develop PR before retrying deployment.
AWS response schema: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_DeploymentCircuitBreaker.html