fix(webapp,redis-worker): stop logging raw metadata, alert payloads, and job items - #4403
Conversation
…and job items Debug logging around run metadata writes previously included the full, unfiltered metadata object on every flush. It now logs key/operation counts and byte sizes instead, and skips the log entirely when there is nothing buffered. The webapp logger's redaction list also now covers `metadata` and `seedMetadata` as a backstop. Alert webhook delivery failures no longer log the outgoing request body or the (useless, non-serializable) HMAC signature; they log the response status, the webhook URL host, and the relevant ids instead. The redis-worker's failure, retry, and dead-letter logs no longer include the raw job item. The item is still retrievable by id when needed, and the default worker logger now filters the `item` key as a backstop.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughLogging configuration now includes metadata fields. Metadata packet handling exposes byte lengths, and metadata update logs use aggregate counts and byte sizes instead of raw objects. Webhook delivery logs include webhook/run identifiers and a sanitized URL host while excluding request payloads and signatures. Redis worker error and retry logs use job identifiers without emitting raw queue items or payloads. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
2 participants
Summary
Debug logging around run metadata writes previously included the full,
unfiltered metadata object on every flush, so credentials and other
sensitive customer-controlled data could end up in application logs. It now
logs key/operation counts and byte sizes instead, and skips the log
entirely when there is nothing buffered. The webapp logger's redaction list
also now covers
metadataandseedMetadataas a backstop.Alert webhook delivery failures no longer log the outgoing request body or
the (useless, non-serializable) HMAC signature; they log the response
status, the webhook URL host, and the relevant ids instead.
The redis-worker's failure, retry, and dead-letter logs no longer include
the raw job item. The item is still retrievable by id when needed, and the
default worker logger now filters the
itemkey as a backstop.Design
Each call site was already computing everything needed to reproduce or
triage a failure without the raw payload (ids, counts, sizes, statuses), so
this trades verbose-by-default logging for those cheaper, non-sensitive
signals.
Performance
Improves hot path performance relative to baseline.