feat(vm): optimize TVM delegate and undelegate execution - #6920
Open
ouy95917 wants to merge 1 commit into
Open
Conversation
| } | ||
|
|
||
| @Test | ||
| public void testSuicide2RejectsSelfDestructedBeneficiaryAfterFork() |
Collaborator
There was a problem hiding this comment.
Could we also add a pre-fork case asserting that suicide2() succeeds when VERSION_4_8_2_2 is not activated? Since the beneficiary check is invoked unconditionally and gated inside MUtil, this would explicitly protect backward compatibility before the fork.
| } | ||
|
|
||
| @Test | ||
| public void testSuicide2RejectsSelfDestructedBeneficiaryAfterFork() |
Collaborator
There was a problem hiding this comment.
Could we also add a pre-fork case asserting that suicide2() succeeds when VERSION_4_8_2_2 is not activated? Since the beneficiary check is invoked unconditionally and gated inside MUtil, this would explicitly protect backward compatibility before the fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR optimizes the execution of SELFDESTRUCT, FreezeBalanceV2, UnfreezeBalanceV2, WithdrawExpireUnfreeze, and CancelAllUnfreezeV2 by exiting early in specific edge cases to improve performance.
Why are these changes required?
To streamline the related execution paths and improve processing efficiency in specific scenarios.
This PR has been tested by:
Follow up
The release and activation plans will be evaluated separately.
Extra details
The version identifier used in this PR is provisional and may be adjusted later.