Update VCP to v3.2.0, split calendar/datepicker components - #42856
Open
mdo wants to merge 3 commits into
Open
Conversation
VCP 3.2.0 wraps the months and years in row and cell elements to fix their ARIA grid structure. That change moves the grid columns off the container, so put the column grid on the new row elements. The month and year views otherwise collapse to three rows. Also split the calendar grid out of the datepicker into its own Sass partial and token map. The datepicker now layers the popup surface onto a bare calendar, instead of inline calendars undoing the popup styling. Use the `--calendar-*` tokens to style a calendar and the `--datepicker-*` tokens to style the popup. Add unit tests that pin the month and year markup, because this regression was invisible to the suite. Closes #42836
The calendar now has its own Sass partial and token map, so document it apart from the datepicker. The page covers the inline calendar, the `--calendar-*` tokens, and the color modes. Point at the datepicker for options, methods, and events, because the calendar has no JavaScript of its own.
The bundle build inlines Vanilla Calendar Pro, so the v3.2.0 row and cell markup adds 555 bytes gzipped to `bootstrap.bundle.min.js`. That puts the file at 55.75 kB, above the 55.5 kB budget.
mdo
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vanilla-calendar-proto v3.2.0 inpackage.json, the lockfile, and the CDN URL inconfig.yml_datepicker.scssinto a newscss/_calendar.scsswith its own token map. The datepicker now layers the popup surface onto a bare calendar, instead of inline calendars undoing the popup styling--calendar-*tokens and the popup with the--datepicker-*tokens. The popup passes its padding down through--calendar-paddingdata-vc-inputpopup/inline distinction, because this regression was invisible to the suiteFixes #42836