feat(orchestrator): add pipeline self-declaration - #404
Open
JamyDev wants to merge 3 commits into
Open
Conversation
JamyDev
changed the title
This was referenced Jul 20, 2026
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 21, 2026 17:59
e091f18 to
538faea
Compare
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 23, 2026 00:28
538faea to
1a44af2
Compare
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 24, 2026 16:55
1a44af2 to
ac8e2fe
Compare
JamyDev
marked this pull request as ready for review
July 24, 2026 17:31
JamyDev
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 24, 2026 17:31
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 24, 2026 18:09
ac8e2fe to
b676033
Compare
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 24, 2026 18:32
b676033 to
ebbfac0
Compare
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 24, 2026 18:42
ebbfac0 to
d8c5add
Compare
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
2 times, most recently
from
July 24, 2026 19:02
c09aea1 to
a3d65e3
Compare
behinddwalls
approved these changes
Jul 24, 2026
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 29, 2026 17:48
a3d65e3 to
4655d7a
Compare
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 30, 2026 05:44
4655d7a to
e3743d4
Compare
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Jul 30, 2026
Introduce `submitqueue/orchestrator/pipeline.go` with three exports: - `Deps` struct: the full set of dependencies (logger, scope, storage, counter, and four extension factories) the orchestrator pipeline needs. This struct IS the service's public API toward deployers. - `Stages` slice: the complete 12-stage pipeline topology as a typed table of `pipeline.Stage[Deps]`. Each row declares a primary controller constructor and its DLQ reconciler. Adding a stage = adding one row. - `PublishOnlyTopics`: topics the orchestrator publishes to but does not consume (log, merge-conflict-check, runway-merge). - `Controllers` struct + `NewControllers`: RPC-facing controllers (currently Ping), NOT bound to any wire contract. Pure addition alongside the existing main.go wiring — no behavioral changes. Ref: doc/rfc/submitqueue/modular-queue-wiring.md (Step 3) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The score controller package does not exist — scoring was folded into the speculator. Remove the score stage from Stages, the Scorer field from Deps, and the controller/score import. Update the pipeline diagram comment accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
One consumer group ("orchestrator") for all topics in the service,
matching the convention that per-stage groups are unnecessary unless
instances are split by stage.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JamyDev
force-pushed
the
jamy/orchestrator-pipeline
branch
from
July 30, 2026 06:06
e3743d4 to
4d386f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submitqueue/orchestrator/pipeline.gowith the orchestrator's self-declarationDepsstruct: logger, scope, storage, counter, and four extension factories — the service's public API toward deployersStages: all 12 pipeline stages as a[]pipeline.Stage[Deps]typed table, each with primary controller + DLQ reconcilerPublishOnlyTopics: log, merge-conflict-check, runway-mergeControllersstruct +NewControllers: RPC controllers (Ping), not bound to any wire contractStep 3 of the Modular Queue Wiring RFC. Stacked on #403.
Test plan
bazel build //submitqueue/orchestrator:go_default_librarycompilesmake gazelle— BUILD.bazel in syncmake fmt— code formattedIssues
https://linear.app/uber/issue/CODEM-209/example-figure-out-a-better-structure-for-wiring-up
Stack