fix(cancel): resolve durable batch ownership - #454
Open
ubettigole wants to merge 1 commit into
Open
Conversation
Use request-to-batch assignments with a legacy all-state fallback and retry while a claimed request's batch is not yet visible. Jira Issues: CODEM-304
This was referenced Jul 29, 2026
ubettigole
marked this pull request as ready for review
July 29, 2026 00:40
ubettigole
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 29, 2026 00:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cancellation can race with batching after a request is claimed as
Batchedbut before its batch or assignment becomes visible. The cancel controller can then take the request-only cancellation path while the batch controller subsequently persists an orphan batch, allowing invalid work to continue.This PR makes cancellation resolve durable request-to-batch ownership, with an all-state fallback for legacy or partially persisted data. It retries during the claim-to-batch visibility window, waits for
Creatingbatches to finish structural initialization, and preserves terminal batch outcomes instead of overwriting them with request-only cancellation.Test Plan
Unit tests
Issues
#354
Stack