Skip to content

Update tf_thaw_set in global_cycle (production/GFS.v17.0.0) - #1163

Merged
BrianCurtis-NOAA merged 1 commit into
ufs-community:production/GFS.v17.0.0from
DavidHuber-NOAA:fix/v17_stability
Jun 30, 2026
Merged

Update tf_thaw_set in global_cycle (production/GFS.v17.0.0)#1163
BrianCurtis-NOAA merged 1 commit into
ufs-community:production/GFS.v17.0.0from
DavidHuber-NOAA:fix/v17_stability

Conversation

@DavidHuber-NOAA

@DavidHuber-NOAA DavidHuber-NOAA commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:

This is a cherry-pick of #1155 for the GFS v17 production branch. This addresses a stability issue found during GCAFS testing.

GENERATIVE AI USAGE

Transparency in the use of generative AI is required by NOAA policy.

  • GenAI is NOT used in this work
  • GenAI is used in this work: (INSERT GENERATIVE AI TOOL HERE)
    • The code has been reviewed, edited, and validated by NWS staff.

TESTING

Fully tested in GCAFS. Regression testing in progress on Ursa and WCOSS2.

WHICH CONSISTENCY TESTS TO RUN:

  • chgres_cube
  • cpld_gridgen
  • global_cycle
  • grid_gen
  • ice_blend
  • ocnice_prep
  • regrid_sfc
  • snow2mdl
  • weight_gen

TESTS CONDUCTED:

  • Compile branch using Intel:
    • Orion
    • Ursa
    • Hercules
    • WCOSS2
  • Compile branch using GNU:
    • Ursa
  • Compile branch in 'Debug' mode:
    • WCOSS2
  • Compile with Doxygen with no errors.
  • Run unit tests on any Tier 1 machine.
  • Run relevant consistency tests:
    • Orion
    • Ursa
    • Hercules
    • WCOSS2

Optional test.

  • Run full set of chgres_cube consistency tests on Ursa.

Describe any additional tests performed.

DEPENDENCIES:

DOCUMENTATION:

  • Doxygen does not need updates.
  • Doxygen is updated.

LINKED ISSUES:

CONTRIBUTORS (optional):

@BrianCurtis-NOAA

Copy link
Copy Markdown
Collaborator

Do you need me to run testing on WCOSS2? Has GW side tested this thoroughly enough for your liking?

@DavidHuber-NOAA

Copy link
Copy Markdown
Collaborator Author

@BrianCurtis-NOAA that would be great if you run the testing on WCOSS2. I think this has been tested well enough in the workflow, but will defer to Travis.

@TravisElless-NOAA do we need to do any additional testing in the workflow for this?

@BrianCurtis-NOAA

Copy link
Copy Markdown
Collaborator

CTests and Reg-test for global_cycle all pass on WCOSS2. Build with Release and Debug mode is a success as well.

@TravisElless-NOAA

Copy link
Copy Markdown
Contributor

I'm pretty sure I tested #1155 fairly thoroughly so I think it should be good from the GW side.

@DavidHuber-NOAA

Copy link
Copy Markdown
Collaborator Author

Thanks @BrianCurtis-NOAA and @TravisElless-NOAA! Opening for review.

@DavidHuber-NOAA
DavidHuber-NOAA marked this pull request as ready for review June 24, 2026 19:54
@BrianCurtis-NOAA

Copy link
Copy Markdown
Collaborator

Anything else needed here before merge?

@DavidHuber-NOAA

Copy link
Copy Markdown
Collaborator Author

No, I think this is good to go.

@BrianCurtis-NOAA
BrianCurtis-NOAA merged commit 33aecfa into ufs-community:production/GFS.v17.0.0 Jun 30, 2026
2 of 4 checks passed
@DavidHuber-NOAA
DavidHuber-NOAA deleted the fix/v17_stability branch June 30, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants