Update tf_thaw_set in global_cycle (production/GFS.v17.0.0) - #1163
Merged
BrianCurtis-NOAA merged 1 commit intoJun 30, 2026
Merged
Conversation
Collaborator
|
Do you need me to run testing on WCOSS2? Has GW side tested this thoroughly enough for your liking? |
Collaborator
Author
|
@BrianCurtis-NOAA that would be great if you run the testing on WCOSS2. I think this has been tested well enough in the workflow, but will defer to Travis. @TravisElless-NOAA do we need to do any additional testing in the workflow for this? |
Collaborator
|
CTests and Reg-test for global_cycle all pass on WCOSS2. Build with Release and Debug mode is a success as well. |
Contributor
|
I'm pretty sure I tested #1155 fairly thoroughly so I think it should be good from the GW side. |
Collaborator
Author
|
Thanks @BrianCurtis-NOAA and @TravisElless-NOAA! Opening for review. |
DavidHuber-NOAA
marked this pull request as ready for review
June 24, 2026 19:54
BrianCurtis-NOAA
approved these changes
Jun 24, 2026
CatherineThomas-NOAA
approved these changes
Jun 30, 2026
Collaborator
|
Anything else needed here before merge? |
Collaborator
Author
|
No, I think this is good to go. |
BrianCurtis-NOAA
merged commit Jun 30, 2026
33aecfa
into
ufs-community:production/GFS.v17.0.0
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This is a cherry-pick of #1155 for the GFS v17 production branch. This addresses a stability issue found during GCAFS testing.
GENERATIVE AI USAGE
Transparency in the use of generative AI is required by NOAA policy.
TESTING
Fully tested in GCAFS. Regression testing in progress on Ursa and WCOSS2.
WHICH CONSISTENCY TESTS TO RUN:
TESTS CONDUCTED:
Optional test.
Describe any additional tests performed.
DEPENDENCIES:
DOCUMENTATION:
LINKED ISSUES:
CONTRIBUTORS (optional):