[develop] Fix for nightly runs - #1372
Conversation
MichaelLueken
left a comment
There was a problem hiding this comment.
Thanks for making the necessary fix to allow the SRW to run on CSPs! The addition to the NOAA Cloud python_srw.lua file are similar to those made in the Gaea C6 python_srw.lua file and it looks good to me.
Approving now.
|
The Gaea C6 Jenkins runner is down, so I will manually run the coverage WE2E tests on that platform. |
|
The Gaea C6 coverage WE2E tests have successfully passed: Awaiting completion of the rest of the Jenkins tests now. |
|
The Jenkins tests have successfully passed on Hercules, Orion, Ursa GNU, and Ursa Intel. Still awaiting WE2E tests to complete on Derecho. The FunctionalWorkflowTaskTests stage has failed on Azure, and is still running on PC AWS - https://jenkins.epic.oarcloud.noaa.gov/blue/organizations/jenkins/ufs-srweather-app%2Fpipeline/detail/PR-1372/1/pipeline/719 |
|
It looks like the modification that was made to allow the WE2E tests to run on NOAA Cloud isn't working for the WorkflowTaskTests stage, which tests the ability to run a test using stand-alone scripts (the Azure test has failed and the PC AWS test has been running for close to an hour). We will need to address this, as the nightly builds run this test stage before the skill-score test. On Azure, it looks like it ran for 8 minutes, which could be enough time to reach the |
Thank you @MichaelLueken for reporting this failure. The reason why it is failing is because the missing GNU library isn't being loaded during the WorkflowTaskTests stage, which uses the stand-alone scripts. My change was only in the noaacloud task module file, which doesn't get loaded with the stand-alone scripts. To resolve this failure, I would need to make changes the build noaa cloud module file since that is what is being loaded with the stand-alone scripts. I'll make this change shortly. |
|
Thanks, @EdwardSnyder-NOAA! I can confirm that the Jenkins tests successfully completed for Derecho, Gaea C6, Hercules, Orion, Ursa GNU, and Ursa Intel. I will rerun the tests on CSPs now. |
|
The Jenkins tests have successfully passed on Azure: |
|
On PW AWS, three tests passed, while three tests failed: Will rerun the three failed tests to see if they successfully pass. |
|
The three tests failed once again in the |
|
The
The Jenkins run can be found - https://jenkins.epic.oarcloud.noaa.gov/blue/organizations/jenkins/ufs-srweather-app%2Fpipeline/detail/PR-1372/6/pipeline |
|
These three experiments are failing in the I dug through the code and cannot find the source of this error. What is even more frustrating is that these same experiments pass with my PW AWS instance. The only difference between my PW AWS configuration and Kris's is he using a different
My intuition tells me there is something wrong with Kris's profile or configuration since the experiments passed with my AWS configuration. I'm unsure how to precede, so any guidance or suggestions are welcomed. |
|
Thanks for digging into this. I'd recommend replacing the |
I shuffled around the tests, and confirmed that the new tests for AWS do pass. Feel free to rerun the Jenkins job again. |
|
Thanks, @EdwardSnyder-NOAA! I can confirm that the updated coverage test suite successfully passes on PW AWS: Merging this PR now. |
DESCRIPTION OF CHANGES:
The AWS Jenkins nightly runs are failing. Initially it was due to lack of staged SRW data, but that was resolved, which led to failures in the
make_sfc_climotask. This failure was captured in issue #1328. Troubleshooting and testing revealed that the executables where built with a newer GNU version than what is used at runtime, causing the executables to fail. The easiest solution is to load this missing GNU library before the executables run.Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
This resolves issue #1328.
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
@benkozi