Upgrade WM to spack-stack 2.1.x

[gspetro-NOAA]

Commit Queue Requirements:

• This PR addresses a relevant WM issue (if not, create an issue).
• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
  • Commit log file w/full results from RT suite run (if applicable).
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

---

Description:

Upgrade the WM to spack-stack v2.1.1.

Commit Message:

* UFSWM - Upgrade the WM to spack-stack v2.1.1
  * AQM - 
  * CATChem - workaround for Gaea C6 oneapi compiler bug
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * UFSATM - TBD subcomponent hash updates
    * ccpp-physics - TBD
    * atmos_cubed_sphere - rm sst_ncep & sst_anom
    * UPP - TBD
  * GOCART - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - rm deprecated compiler flag
  * fire_behavior - rm deprecated compiler flag
  * stochastic_physics - 

Priority:

• Critical Bugfix: Reason
• High: Reason
• Normal

Git Tracking

UFSWM:

• Closes Update UFS-WM to spack-stack/2.1.x #3067
• Closes Move off of sp to ip #3041
• Closes Ursa ufs_ursa.intelllvm.lua selects the wrong underlying Fortran compiler #3233
• Closes intelllvm failed cases on Hercules #2706
• Closes s2swa_32bit_oneapi & atmaero_oneapi compile failures on GaeaC6 w/spack-stack v2.1.0 #3213
• Closes Cover more RT builds with WARN_AS_ERROR #3316

Derecho will likely stay on v1.9.2 for now, so these issues remain open:

• Derecho-specific issues for the WM spack-stack v2.1.x upgrade #3306

Sub component Pull Requests:

• AQM:
• CATChem: fix(build): upgrade UFS WM to spack-stack v2.1.x CATChem#192
• CDEPS:
• CICE:
• CMEPS:
• CMakeModules:
• UFSATM: Upgrade WM to spack-stack 2.1.x NOAA-EMC/ufsatm#1088
  • ccpp-physics: Upgrade WM to spack-stack 2.1.x ccpp-physics#368
  • atmos_cubed_sphere: Upgrade WM to spack-stack 2.1.x NOAA-GFDL/GFDL_atmos_cubed_sphere#410
  • UPP: Upgrade WM to spack-stack 2.1.x NOAA-EMC/UPP#1490
• GOCART:
• LM4:
• MOM6:
• NOAHMP:
• WW3: Upgrade UFS WM to spack-stack v2.1.x NOAA-EMC/WW3#1614
• fire_behavior: Upgrade WM to spack-stack 2.1.x NOAA-EMC/fire_behavior#6
• stochastic_physics:

UFSWM Blocking Dependencies:

• Blocked by Derecho-specific issues for the WM spack-stack v2.1.x upgrade #3306
• None

Documentation:

• Documentation update required.
  • Relevant updates are included with this PR.
  • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
• Documentation update NOT required.
  • Explanation:

Contributors (optional):

@RatkoVasic-NOAA @rickgrubin-noaa

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Adds New Tests/Baselines.
• PR Updates/Changes Baselines.
• No Baseline Changes.

Input data Changes:

• None.
• PR adds input data.
• PR changes existing input data.

Library Changes/Upgrades:

• Required
  • Library names w/versions:
  • Git Stack Issue (JCSDA/spack-stack#)
• No Updates
  No specific library requests, but the whole stack is being updated collectively...

---

Testing Log:

• RDHPCS
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

Testing Remarks:

[gspetro-NOAA]

@JessicaMeixner-NOAA @mingchen-NOAA On Hercules only, there is an increase in warnings for compile_s2sw_32bit_pdlib_debug_gnu. I'm guessing the scotch fix somehow influenced this? In any case, what I'm seeing is 10 more -Winteger-division warnings from:

• WW3/model/src/pdlib_field_vec.F90 (+6)
• WW3/model/src/w3iorsmd.F90 (+3)
• WW3/model/src/w3iobcmd.F90 (+1)

(plus a decrease of 1 in WW3/model/src/w3ounfmetamd.F90 for a total of 9). Should I open an issue in WW3? I'm still comparing the intel and oneapi results for that compile but will report back soon on those results!

UPDATE: No increase in warnings for the compile_s2sw_32bit_pdlib_debug_oneapi compile compared to its intel equivalent! 🙂

[mingchen-NOAA]

@gspetro-NOAA I will check these warnings and fix them with PR#3318.

[JessicaMeixner-NOAA]

@gspetro-NOAA are the WW3 warnings holding this PR back?

[gspetro-NOAA]

@JessicaMeixner-NOAA In theory, we are not supposed merge anything that increases compiler warnings. However, at the moment, the biggest holdup is Derecho. All tests pass on other EPIC-supported systems, but most tests won't even compile on Derecho. There is some high-level conversation happening at the exec level, because it seems to be a system/environment issue, but I have not been privy to the details. Will be following up today with management though because you are not the only one wondering what is happening with this PR...

Anyway, ideally we want to resolve the WW3 warnings before merging this PR. However, even once those warnings are fixed, there is the Derecho issue, so strictly speaking, the WW3 warnings are not holding up this PR at the moment.

[mingchen-NOAA]

@gspetro-NOAA I am testing the fixes for the warnings and remarks on Hercules. The additional warnings in compile_s2sw_32bit_pdlib_debug_gnu have been resolved. However, all oneapi compilations are failing with the following messages:

/work/noaa/marine/Ming.Chen/hercules/ufswm/mchen1/stmp/mchen1/FV3_RT/rt_3127083/compile_s2sw_pdlib_oneapi/build_fv3_s2sw_pdlib_oneapi/UFSATM/ccpp/ccpp/ccpp_FV3_GFS_v17_coup
led_p8_ugwpv1_cap.F90(233): error #5462: Global name too long, shortened from: ccpp_fv3_gfs_v17_coupled_p8_ugwpv1_cap_mp_FV3_GFS_V17_COUPLED_P8_UGWPV1_PHYSICS_TIMESTEP_INIT
 to: p_fv3_gfs_v17_coupled_p8_ugwpv1_cap_mp_FV3_GFS_V17_COUPLED_P8_UGWPV1_PHYSICS_TIMESTEP_INIT
  subroutine FV3_GFS_v17_coupled_p8_ugwpv1_physics_timestep_init( &
-------------^
/work/noaa/marine/Ming.Chen/hercules/ufswm/mchen1/stmp/mchen1/FV3_RT/rt_3127083/compile_s2sw_pdlib_oneapi/build_fv3_s2sw_pdlib_oneapi/UFSATM/ccpp/ccpp/ccpp_FV3_GFS_v17_coup
led_p8_ugwpv1_cap.F90(527): error #5462: Global name too long, shortened from: ccpp_fv3_gfs_v17_coupled_p8_ugwpv1_cap_mp_FV3_GFS_V17_COUPLED_P8_UGWPV1_PHYSICS_TIMESTEP_FINA
L to: _fv3_gfs_v17_coupled_p8_ugwpv1_cap_mp_FV3_GFS_V17_COUPLED_P8_UGWPV1_PHYSICS_TIMESTEP_FINAL
  subroutine FV3_GFS_v17_coupled_p8_ugwpv1_physics_timestep_final( &
-------------^
compilation aborted for /work/noaa/marine/Ming.Chen/hercules/ufswm/mchen1/stmp/mchen1/FV3_RT/rt_3127083/compile_s2sw_pdlib_oneapi/build_fv3_s2sw_pdlib_oneapi/UFSATM/ccpp/cc
pp/ccpp_FV3_GFS_v17_coupled_p8_ugwpv1_cap.F90 (code 1)