Skip to content

Draft: Add shared quality control module to log or fail variables out-of-range - #3278

Draft
NickSzapiro-NOAA wants to merge 14 commits into
ufs-community:developfrom
NickSzapiro-NOAA:qc_coupling
Draft

Draft: Add shared quality control module to log or fail variables out-of-range#3278
NickSzapiro-NOAA wants to merge 14 commits into
ufs-community:developfrom
NickSzapiro-NOAA:qc_coupling

Conversation

@NickSzapiro-NOAA

@NickSzapiro-NOAA NickSzapiro-NOAA commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Transparency in the use of generative AI is required by NOAA policy. Was GenAI used in this work?
    • [Gemini AI] was used to assist with developing this code. The code has been reviewed, edited, and validated by NWS staff.
  • Fill out all sections of this template.

Description:

Shared quality control module to log or fail if variables go out-of-range during simulation, via namelist input of var_name, qc_min, qc_max

Commit Message:

* UFSWM - 
  * AQM - 
  * CATChem - 
  * CDEPS - 
  * CECE - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * UFSATM - 
    * ccpp-physics -
      * CCPP submodules (list) - 
    * atmos_cubed_sphere -
    * MPAS
  * GOCART -
  * LM4 - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

  • Closes #

Sub component Pull Requests:

  • UFSWM -
    • AQM -
    • CATChem -
    • CDEPS -
    • CECE -
    • CICE -
    • CMEPS -
    • CMakeModules -
    • UFSATM -
      • ccpp-physics -
        • CCPP submodules (list) -
      • atmos_cubed_sphere -
      • MPAS
    • GOCART -
    • LM4 -
    • MOM6 -
    • NOAHMP -
    • WW3 -
    • fire_behavior
    • stochastic_physics -
  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Testing Remarks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Draft

Development

Successfully merging this pull request may close these issues.

2 participants