Skip to content

Refactor SAMF convection schemes for single-precision (32-bit) capability - CCPP - #3341

Draft
rhaesung wants to merge 45 commits into
ufs-community:developfrom
rhaesung:feature/samf-single-precision
Draft

Refactor SAMF convection schemes for single-precision (32-bit) capability - CCPP#3341
rhaesung wants to merge 45 commits into
ufs-community:developfrom
rhaesung:feature/samf-single-precision

Conversation

@rhaesung

Copy link
Copy Markdown
Contributor

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Transparency in the use of generative AI is required by NOAA policy. Was GenAI used in this work?
    • [Generative AI tool (insert name, if any)] was used to assist with developing this code. The code has been reviewed, edited, and validated by NWS staff.
  • Fill out all sections of this template.

Description:

  • Added CMake build option SAMFCNV_USE_SP to enable single-precision compilation for the SAMF convection scheme.
  • Added a dedicated 32-bit test configuration (control_p8_samf_conv32_intel) to the UFS Regression Test (RT) framework.

Commit Message:

* UFSWM - 
  * AQM - 
  * CATChem - 
  * CDEPS - 
  * CECE - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * UFSATM - 
    * ccpp-physics -
      * CCPP submodules (list) - 
    * atmos_cubed_sphere -
    * MPAS
  * GOCART -
  * LM4 - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Testing Remarks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Evaluating

Development

Successfully merging this pull request may close these issues.

1 participant