Skip to content

Add FRAM for freezing rain diagnosis - #3351

Open
RuiyuSun wants to merge 4 commits into
ufs-community:developfrom
RuiyuSun:FRAM
Open

Add FRAM for freezing rain diagnosis#3351
RuiyuSun wants to merge 4 commits into
ufs-community:developfrom
RuiyuSun:FRAM

Conversation

@RuiyuSun

@RuiyuSun RuiyuSun commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Transparency in the use of generative AI is required by NOAA policy. Was GenAI used in this work?
    • No.
    • Yes. [Generative AI tool (insert name, if any)] was used to assist with developing this code.
      • The code has been reviewed, edited, and validated by NWS staff. (Note: If the code has not yet been reviewed by NWS staff, leave unchecked, and OMD CMs will review as part of the PR review process.)
  • Fill out all sections of this template.

Description:

This PR is to add the Freezing Rain Accumulation Model (FRAM) for freezing rain diagnosis, Test results can be found here.

Commit Message:

use my ufsatm
update log files

  • UFSWM -
    • UFSATM -change ccpp/physics branch to FRAM; correct the branch name
      • ccpp-physics -add FRAM

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation:

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Testing Remarks:

@github-project-automation github-project-automation Bot moved this to Evaluating in PRs to Process Sep 2, 2026
@gspetro-NOAA gspetro-NOAA added UFSATM There are changes to the UFSATM repository. CCPP There are changes to a CCPP repository. Baseline Updates Current baselines will be updated. labels Sep 3, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Pre-testing required in PRs to Process Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. CCPP There are changes to a CCPP repository. UFSATM There are changes to the UFSATM repository.

Projects

Status: Pre-testing required

Development

Successfully merging this pull request may close these issues.

Add FRAM for freezing rain diagnosis

2 participants