Updates for AIGFS work - #957
Merged
Merged
Conversation
maddenp-cu
commented
Jul 29, 2026
maddenp-cu
marked this pull request as ready for review
July 29, 2026 05:34
maddenp-cu
requested review from
christinaholtNOAA and
elcarpenterNOAA
as code owners
July 29, 2026 05:34
christinaholtNOAA
approved these changes
Jul 29, 2026
elcarpenterNOAA
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Working on AIGFS, I noticed a possibility for three improvements:
uwtools.api.utils.run_shell_cmd(), the directory specified bycwdmust already exist. As of this PR, and as in general inuwtools, the required directory is created if it does not already exist.uwtools.api.utils.run_shell_cmd(), whentasknameis provided, it was being prepended for only some of the log messages. This PR corrects that. See below for example bad output.atomic()context manager is borrowed fromwxvx, added touwtools.utils.file, and exposed via the API. See the corresponding unit test for an example use case.Here's some output from some AIGFS testing I was doing:
Never mind the error, but note that the second and third log messages anomalously are not prefixed with the taskname.
Type
Impact
Checklist