Always log errors in run_shell_cmd() - #963
Merged
Merged
Conversation
maddenp-cu
marked this pull request as ready for review
August 17, 2026 18:36
maddenp-cu
requested review from
christinaholtNOAA and
elcarpenterNOAA
as code owners
August 17, 2026 18:36
elcarpenterNOAA
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Prior to a recent revamp of
uwtools.utils.processing.run_shell_cmd(), errors resulting from a failed shell command were always logged, even whenquiet=Truewas specified. The revamp inadvertently (?) changed this, leading to behavior likewhen the
rocotosystem module is not loaded such thatrocotorunis not available. The error is displayed only if the--verboseflag is specified:But users should not have to specify
--verboseto see an error like this.This PR updates
run_shell_cmd()so that the error behavior above is nowType
Impact
Checklist