Pass task name to rocotorun to avoid erroneously running all tasks - #964
Merged
maddenp-cu merged 3 commits intoAug 18, 2026
Merged
Conversation
maddenp-cu
commented
Aug 18, 2026
maddenp-cu
marked this pull request as ready for review
August 18, 2026 02:40
maddenp-cu
requested review from
christinaholtNOAA and
elcarpenterNOAA
as code owners
August 18, 2026 02:40
elcarpenterNOAA
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
uw rocoto iterate-t/--taskoption torocotorunto prevent it from running all tasks when the named task does not exist.uwtools.rocotoand intouwtools.strings.For example, currently, using the AIGFS workflow as an example, running
where no task named
fooexists, results ini.e. the
preptask starts running. If it succeeds, further iteration will run theforecasttask, etc. Althoughrocotorunhas a-a/--allflag to request execution of all tasks, this seems to also be the default behavior when no task is specified, anduw rocoto iteratecurrently does not provide a task name.This PR passes the
-t <taskname>torocotorun. This prevents Rocoto from executing anything when a bogus task name is provided, which is an improvement. I would prefer to detect that a bogus task name was provided and haltuw, but I have not found a way to do this: The Rocoto database does not even exist untilrocotorunis called and, even then, thejobstable appears only to be populated with task information as tasks become eligible to run. Short of parsing the Rocoto XML ourselves -- and expanding metatask names, which seems risky -- this may be the best easy solution.Type
Impact
Checklist