chore: allow utopia-php/cache 5.* - #4
Merged
Merged
Conversation
Cache 5.0.0 is released and this package pinned 4.*, which blocks consumers downstream: appwrite-labs/cloud cannot resolve circuit-breaker 0.4 while feed still holds cache to the 4 series. Nothing here needs to change for it. Cache's major covers Redis\Multiplexing deadline handling and the move to circuit-breaker ^0.4, which dropped the threshold argument. This package uses neither — only Utopia\Cache\Cache and Utopia\Cache\Adapter, which are identical between 4 and 5. Constrained as 4.* || 5.* so this does not force the upgrade on anyone still on cache 4. Verified: unit 121/121, cache 146/146, redis 155/155 (run inside the tests container, where the compose network resolves). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Greptile SummaryBroadens compatibility to allow either utopia-php/cache 4.x or 5.x without forcing consumers to upgrade.
Confidence Score: 5/5The PR appears safe to merge with no concrete compatibility or security failures identified. The repository uses cache APIs that remain compatible across the allowed versions, does not directly use the upgraded circuit-breaker API, and the resolved lock dependency graph is internally consistent. Important Files Changed
Reviews (1): Last reviewed commit: "chore: allow utopia-php/cache 5.*" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
utopia-php/cache5.0.0 is out. This package pins4.*, and because Composer resolves the whole graph that blocks consumers downstream —appwrite-labs/cloudcannot move tocircuit-breaker 0.4while feed still holds cache to the 4 series.Why this is safe
Cache 5.0.0's major is not about the general cache API, which is unchanged. It is a major for two reasons:
Redis\Multiplexingchanged how a per-call read deadline is handled — a timeout no longer tears down the shared connection (utopia-php/monorepo#152).circuit-breaker ^0.4, which removed thethresholdconstructor argument in favour of a failure rate (utopia-php/monorepo#153).This package uses neither. Grepping
src/andtests/forMultiplexingandCircuitBreakerreturns nothing; the only imports areUtopia\Cache\CacheandUtopia\Cache\Adapter(src/Feed/Cursor/Cache.php,src/Feed/Store/Cache.php), which are identical across the two majors.Verified
test:unittest:cachetest:redisThe redis suite resolves the
redishostname on the compose network, so it has to run inside thetestscontainer (docker compose exec tests composer test:redis) rather than from the host — worth knowing if you have seen it error withgetaddrinfo for redis failed.Lock moves exactly two packages:
cache 4.0.1 → 5.0.0andcircuit-breaker 0.3.1 → 0.4.0.Constraint
4.* || 5.*rather than5.*, so this does not force the upgrade on anyone still on cache 4.Context
Same pass already merged and released for the other three requirers: utopia-php/database#943 (7.2.6), utopia-php/domains#70 (3.0.1), utopia-php/vcs#137 (5.2.3). This was the fourth, found by Composer while resolving cloud.
🤖 Generated with Claude Code