[clementperon]

Today the download log is always downloads.log in LogDir, and the runtime log can only go to a file through the daemon's -log flag. This adds two options:

Option	Default	Meaning
AccessLog	downloads.log	Access log (downloads and HEAD requests). Empty disables it.
RuntimeLog	empty	Runtime log. Empty keeps it on stderr; -log still takes precedence.

Relative names are created in LogDir, absolute paths are used as is. So the defaults behave exactly like today, and a setup can for example send the access log to /dev/null while keeping the runtime log in LogDir:

LogDir: /var/log/mirrorbits
AccessLog: /dev/null
RuntimeLog: runtime.log

Context: Team Kodi runs mirrors.kodi.tv with that kind of configuration (named ErrorLog there), through a patch in its fork (xbmc/mirrorbits@621f3bb). That patch renamed the default download log and joined absolute paths onto LogDir; this version keeps upstream's default and handles absolute paths.

Tests: new TestLogFilePaths covers relative and absolute names, -log precedence, and disabling the access log; make test passes for logs (also with -race). http/TestMirrorHandler3xx fails the same way on master without this change.

🤖 Generated with Claude Code

[jbkempf]

LGTM

[clementperon]

rebase / force push on top of master @elboulangero

[elboulangero]

Why name the option ErrorLog? That's not a good name. It doesn't contain only errors. In the code those logs are referred to as "runtime log" (or RunLog for short), and that's a better name IMO.

AccessLog is a good name (downloads.log became a bit of a misnomer after we started to log HEAD requests in there, which are clearly NOT downloads).

[clementperon]

Why name the option ErrorLog? That's not a good name. It doesn't contain only errors. In the code those logs are referred to as "runtime log" (or RunLog for short), and that's a better name IMO.

AccessLog is a good name (downloads.log became a bit of a misnomer after we started to log HEAD requests in there, which are clearly NOT downloads).

I think it's to be close to what Nginx does.

I have renamed it to RuntimeLog + Update PR description

[elboulangero]

I think it's to be close to what Nginx does.

I've seen the parallel with web servers, but web servers really log errors in their error.log, it's quite different here (it's really a lot of informational messages that go through)

[elboulangero]

Thanks very much @clementperon ! I've looked at the changes and it looks good, happy with it. Thanks again.